Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #check_fetch_offense method #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

connicov1
Copy link

Updated method #check_fetch_offense to verify method #fetch if it has a block and return a correct error message.

Related issue: #37

@DamirSvrtan
Copy link
Owner

Thank you for your contribution! It seems we are reversing this rule - has this rule been reversed in fast-ruby as well?

@connicov1
Copy link
Author

Thank you for your contribution! It seems we are reversing this rule - has this rule been reversed in fast-ruby as well?

Hey, I’ve checked the fast-ruby and there are quite the same logic as I did here. Don’t know why they think a constant as argument is slower than a block, however, all the primitive data types are faster than a block in fast-ruby as well

@gagalago
Copy link

@DamirSvrtan I don't get you comment. This pull request revert this rule only for constant and primitive type, for the rest(method call, object...), this rule is still valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants