Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
content
isn't actually needed for anything in thePdfHighlighter
, it should be removed from theHighlight
type. As stated in #5 , for large numbers of highlights, especially images, this can be beneficial for performance and storage since image content no longer needs to be loaded on every render or stored in a database if not required.Since developers might already be using
content
to determine whether a highlight is an area highlight or text highlight, we simply add a newtype
property that makes this explicit. However, to avoid any breaking changes,type
has been marked as optional andcontent
is kept inHighlight
but made optional.