Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update ngx-vcard.formatter.ts #724

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

iamandersonp
Copy link

add code to enforce ANSI compatibility to work correctly with outlook

add code to enforce ANSI compatibility to work correctly with outlook
@iamandersonp iamandersonp changed the title Update ngx-vcard.formatter.ts feat Update ngx-vcard.formatter.ts May 15, 2023
@iamandersonp iamandersonp changed the title feat Update ngx-vcard.formatter.ts feat: Update ngx-vcard.formatter.ts May 15, 2023
@DanielHabenicht
Copy link
Owner

DanielHabenicht commented May 15, 2023

Thanks for the PR, but which characters are misrepresented in Outlook?
This seems more like a bad input data issue than a problem of the formatter.

@iamandersonp
Copy link
Author

The proble is that outlook doesnt read special characters like á é í ó ú if the file is saved in utf-8, the only way they display correctly is if the file is saved in ANSI, this PR do that, and it doesnt afect others imports, like import it in iphone, android devices or even in contacts in mac, the only afecteds are outlook and windoes contacts

@DanielHabenicht
Copy link
Owner

DanielHabenicht commented May 26, 2023

I think we might have to make this optional and add-in, as it not adhering to the RFC: https://datatracker.ietf.org/doc/html/rfc6350#section-3.1
Also we probably should reuse the encodingPrefix option to add an option for this encoding.

One other thing you might try is set the encoding option in outlook or in the vcard (via encodingPrefix option)
See: https://stackoverflow.com/questions/8617439/utf8-encoding-with-vcards-in-windows

@iamandersonp
Copy link
Author

I think we might have to make this optional and add-in, as it not adhering to the RFC: https://datatracker.ietf.org/doc/html/rfc6350#section-3.1 Also we probably should reuse the encodingPrefix option to add an option for this encoding.

One other thing you might try is set the encoding option in outlook or in the vcard (via encodingPrefix option) See: https://stackoverflow.com/questions/8617439/utf8-encoding-with-vcards-in-windows

None of that works the only solution is re-encoding all the vcard to ansi in wich case afther generating the vCard string you have to use the code i added to do it (I have to generate the vCard string and afther re encode all to ansi to generate the downloadable file and in that process i cannot use the directive from this package)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants