Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(fuzzer): Fix toSql methods for NestedLoopJoinNode in Reference Qu…
Browse files Browse the repository at this point in the history
…ery Runners (facebookincubator#11576)

Summary:

The select clause is completely missing in the produced query string.

Reviewed By: kagamiori

Differential Revision: D66132514
Daniel Hunte authored and facebook-github-bot committed Dec 16, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent 55718e0 commit df1c7c7
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions velox/exec/fuzzer/DuckQueryRunner.cpp
Original file line number Diff line number Diff line change
@@ -449,6 +449,7 @@ std::optional<std::string> DuckQueryRunner::toSql(
std::optional<std::string> DuckQueryRunner::toSql(
const std::shared_ptr<const core::NestedLoopJoinNode>& joinNode) {
std::stringstream sql;
sql << "SELECT " << folly::join(", ", joinNode->outputType()->names());

// Nested loop join without filter.
VELOX_CHECK(
1 change: 1 addition & 0 deletions velox/exec/fuzzer/PrestoQueryRunner.cpp
Original file line number Diff line number Diff line change
@@ -669,6 +669,7 @@ std::optional<std::string> PrestoQueryRunner::toSql(
std::optional<std::string> PrestoQueryRunner::toSql(
const std::shared_ptr<const core::NestedLoopJoinNode>& joinNode) {
std::stringstream sql;
sql << "SELECT " << folly::join(", ", joinNode->outputType()->names());

// Nested loop join without filter.
VELOX_CHECK(

0 comments on commit df1c7c7

Please sign in to comment.