Added option to mark user links (in questions/answers/comments) with nofollow

forum/actions/user.py

@@ -13,6 +13,8 @@ def repute_users(self):
         self.repute(self.user, int(settings.INITIAL_REP))
 
     def process_action(self):
+        if not settings.SEND_WELCOME_EMAILS:
+            return
         hash = ValidationHash.objects.create_new(self.user, 'email', [self.user.email])
         send_template_email([self.user], "auth/welcome_email.html", {'validation_code': hash})
 

forum/forms/qanda.py

@@ -5,6 +5,7 @@
 from django.utils.translation import ugettext as _
 
 from django.utils.encoding import smart_unicode
+from django.utils.safestring import mark_safe
 from general import NextUrlField, UserNameField
 
 from forum import settings
@@ -71,7 +72,7 @@ def clean(self, value):
 
 
 class TagNamesField(forms.CharField):
-    def __init__(self, user=None, *args, **kwargs):
+    def __init__(self, user=None, initial='', *args, **kwargs):
         super(TagNamesField, self).__init__(*args, **kwargs)
 
         self.required = True
@@ -82,7 +83,7 @@ def __init__(self, user=None, *args, **kwargs):
         self.help_text = _('Tags are short keywords, with no spaces within. At least %(min)s and up to %(max)s tags can be used.') % {
             'min': settings.FORM_MIN_NUMBER_OF_TAGS, 'max': settings.FORM_MAX_NUMBER_OF_TAGS    
         }
-        self.initial = ''
+        self.initial = initial
         self.user = user
 
     def clean(self, value):
@@ -95,6 +96,16 @@ def clean(self, value):
         list = {}
         for tag in split_re.split(data):
             list[tag] = tag
+
+        if settings.ENFORCE_TAG_FORMAT_FLAG and settings.ENFORCE_TAG_FORMAT_RX and len(str(settings.ENFORCE_TAG_FORMAT_RX.strip())) > 0:
+            try:
+                regexp = re.compile(str(settings.ENFORCE_TAG_FORMAT_RX.strip()))
+                good_tags = [tag for tag in list.values() if regexp.match(tag)]
+                if len(good_tags) == 0:
+                    raise forms.ValidationError(mark_safe(_(settings.ENFORCE_TAG_FORMAT_ERROR_MESSAGE)))
+            except re.error:
+                logging.error("Error while trying to match tags against '%s'" % settings.ENFORCE_TAG_FORMAT_RX)
+                pass
 
         if len(list) > settings.FORM_MAX_NUMBER_OF_TAGS or len(list) < settings.FORM_MIN_NUMBER_OF_TAGS:
             raise forms.ValidationError(_('please use between %(min)s and %(max)s tags') % { 'min': settings.FORM_MIN_NUMBER_OF_TAGS, 'max': settings.FORM_MAX_NUMBER_OF_TAGS})
@@ -175,10 +186,10 @@ class AskForm(forms.Form):
     title  = TitleField()
     text   = QuestionEditorField()
 
-    def __init__(self, data=None, user=None, *args, **kwargs):
+    def __init__(self, data=None, user=None, default_tag='', *args, **kwargs):
         super(AskForm, self).__init__(data, *args, **kwargs)
 
-        self.fields['tags']   = TagNamesField(user)
+        self.fields['tags']   = TagNamesField(user, initial=default_tag)
 
         if int(user.reputation) < settings.CAPTCHA_IF_REP_LESS_THAN and not (user.is_superuser or user.is_staff):
             spam_fields = call_all_handlers('create_anti_spam_field')

forum/management/commands/dump_settings.py

@@ -0,0 +1,27 @@
+from pprint import pformat
+from django.core.management.base import NoArgsCommand
+from forum import settings
+from forum.settings import BaseSetting
+
+class Command(NoArgsCommand):
+    def handle_noargs(self, **options):
+        last_value_default = None
+        for k in dir(settings):
+            attr = getattr(settings, k)
+            if not isinstance(attr, BaseSetting):
+                continue
+            if attr.value == attr.default:
+                if not(last_value_default is None) and last_value_default == False:
+                    print
+                last_value_default = True
+                print "# %s has default value" % k
+                continue
+
+            print
+            last_value_default = False
+            if attr.field_context:
+                if attr.field_context.get('label', None):
+                    print "'''%s'''" % unicode(attr.field_context.get('label'))
+                if attr.field_context.get('help_text', None):
+                    print "'''%s'''" % unicode(attr.field_context.get('help_text'))
+            print "settings.%s = %s" % (k, pformat(attr.value))

forum/management/commands/update_settings.py

@@ -0,0 +1,21 @@
+from django.core.management.base import NoArgsCommand
+from forum import settings as forum_settings
+from settings_osqa import SETTINGS
+
+class Command(NoArgsCommand):
+    def handle_noargs(self, **options):
+        for k, v in SETTINGS.dict.items():
+            try:
+                attr = getattr(forum_settings, k)
+            except AttributeError:
+                print "!!! Attribute %s not found, couldn't set it to %s" % (k, v)
+                continue
+            if attr.value == v:
+                print "# Skipping %s, already has the correct value" % k
+                continue
+            if attr.value != attr.default:
+                print ("!!! Attribute %s has a different value (%s) than its default (%s). " \
+                    + "Won't change it to %s") % (k, attr.value, attr.default, v)
+                continue
+            attr.set_value(v)
+            print "Updated %s" % k

forum/markdownext/mdx_nofollow.py

@@ -0,0 +1,18 @@
+import markdown
+import re
+
+R_NOFOLLOW = re.compile('<a ')
+S_NOFOLLOW = '<a rel="nofollow" '
+
+class NofollowPostprocessor(markdown.postprocessors.Postprocessor):
+    def run(self, text):
+        return R_NOFOLLOW.sub(S_NOFOLLOW, text)
+
+class NofollowExtension(markdown.Extension):
+    """ Add nofollow for links to Markdown. """
+
+    def extendMarkdown(self, md, md_globals):
+        md.postprocessors.add('nofollow', NofollowPostprocessor(md), '_end')
+
+def makeExtension(configs={}):
+    return NofollowExtension(configs=configs)

forum/markdownext/mdx_settingsparser.py

@@ -1,4 +1,8 @@
-from os import linesep
+try:
+    from os import linesep
+except ImportError:
+    linesep = "\n"
+
 from csv import reader, QUOTE_NONE
 import markdown
 from markdown import Extension

forum/models/node.py

@@ -11,7 +11,7 @@
 from django.utils.html import strip_tags
 from forum.utils.html import sanitize_html
 from forum.utils.userlinking import auto_user_link
-from forum.settings import SUMMARY_LENGTH
+from forum.settings import SUMMARY_LENGTH, USE_NOFOLLOW_ON_USER_LINKS
 from utils import PickledObjectField
 
 class NodeContent(models.Model):
@@ -29,7 +29,8 @@ def html(self):
         return self.body
 
     def rendered(self, content):
-        return auto_user_link(self, self._as_markdown(content, *['auto_linker']))
+        extensions = ['auto_linker', 'nofollow'] if USE_NOFOLLOW_ON_USER_LINKS else ['auto_linker']
+        return auto_user_link(self, self._as_markdown(content, *extensions))
 
     @classmethod
     def _as_markdown(cls, content, *extensions):
@@ -486,16 +487,16 @@ def delete(self, *args, **kwargs):
         super(Node, self).delete(*args, **kwargs)
 
     def save(self, *args, **kwargs):
+        if self.parent_id and not self.abs_parent_id:
+            self.abs_parent = self.parent.absolute_parent
+
         if not self.id:
             self.node_type = self.get_type()
             super(BaseModel, self).save(*args, **kwargs)
             self.active_revision = self._create_revision(self.author, 1, title=self.title, tagnames=self.tagnames,
                                                          body=self.body)
             self.activate_revision(self.author, self.active_revision)
             self.update_last_activity(self.author, time=self.added_at)
-
-        if self.parent_id and not self.abs_parent_id:
-            self.abs_parent = self.parent.absolute_parent
 
         tags_changed = self._process_changes_in_tags()
 

forum/models/user.py

@@ -5,6 +5,7 @@
 from django.contrib.contenttypes.models import ContentType
 from django.contrib.auth.models import User as DjangoUser, AnonymousUser as DjangoAnonymousUser
 from django.db.models import Q, Manager
+from django.core.urlresolvers import get_script_prefix
 
 from django.utils.encoding import smart_unicode
 
@@ -230,7 +231,9 @@ def get_profile_url(self):
         return ('user_profile', (), keyword_arguments)
 
     def get_absolute_url(self):
-        return "%s%s" % (django_settings.APP_URL, self.get_profile_url())
+        root_relative_url = self.get_profile_url()
+        relative_url = root_relative_url[len(get_script_prefix()):]
+        return '%s/%s' % (django_settings.APP_URL, relative_url)
 
     @models.permalink
     def get_asked_url(self):

forum/modules/ui_objects.py

@@ -45,6 +45,7 @@ def __invert__(self):
 Visibility.SUPERUSER = Visibility('superuser')
 Visibility.OWNER = Visibility('owner')
 Visibility.REPUTED = lambda r: Visibility(r)
+Visibility.NOBODY = Visibility('public', negated=True)
 
 
 class Url(object):

forum/registry.py

@@ -9,7 +9,6 @@
 from forum.utils.html import cleanup_urls
 from forum import settings
 
-
 try:
     from django.template import get_templatetags_modules
     modules_template_tags = get_modules_script('templatetags')
@@ -77,7 +76,8 @@ def can_render(self, context):
                 url=lambda u, c: reverse('user_authsettings', kwargs={'id': c['user'].id}),
                 span_attrs={'class': 'user-auth'},
                 weight=100,
-                name='AUTH_SETTINGS'
+                name='AUTH_SETTINGS',
+                visibility=ui.Visibility.AUTHENTICATED if settings.USERS_CAN_CHANGE_AUTH_SETTINGS else ui.Visibility.NOBODY,
             ),
             ui.UserMenuItem(
                 label=_("email notification settings"),

forum/settings/email.py

@@ -83,4 +83,9 @@
 help_text = _("If checked the daily digest won't be sent to users that haven't validated their emails."),
 required=False))
 
+SEND_WELCOME_EMAILS = Setting('SEND_WELCOME_EMAILS', True, EMAIL_SET, dict(
+label = _("Send welcome emails"),
+help_text = _("If checked a welcome email will be sent to new users joining the community."),
+required=False))
+
 EMAIL_DIGEST_FLAG = Setting('EMAIL_DIGEST_FLAG', None)

forum/settings/faq.py

@@ -1,7 +1,8 @@
 from base import Setting, SettingSet
 from django.forms.widgets import Textarea
+from django.utils.translation import ugettext_lazy as _
 
-FAQ_SET = SettingSet('faq', 'FAQ page', "Define the text in the about page. You can use markdown and some basic html tags.", 2000, True)
+FAQ_SET = SettingSet('faq', _('FAQ page'), _("Define the text in the about page. You can use markdown and some basic html tags."), 2000, True)
 
 FAQ_PAGE_TEXT = Setting('FAQ_PAGE_TEXT',
 u"""
@@ -74,6 +75,11 @@
 
 Please ask your question, help make our community better!
 """, FAQ_SET, dict(
-label = "FAQ page text",
-help_text = " The faq page. ",
-widget=Textarea(attrs={'rows': '25'})))
+label = _("FAQ page text"),
+help_text = _("The faq page."),
+widget=Textarea(attrs={'rows': '25'})))
+
+FAQ_LINK = Setting('FAQ_LINK', '', FAQ_SET, dict(
+label = _("FAQ link"),
+help_text = _("If not empty, faq page will redirect to this link rather than display the text above"),
+required=False))

forum/settings/form.py

@@ -1,5 +1,5 @@
-import os.path
 from base import Setting, SettingSet
+from django.forms.widgets import Textarea
 from django.utils.translation import ugettext_lazy as _
 
 FORUM_SET = SettingSet('form', _('Form settings'), _("General settings for the OSQA forms."), 10)
@@ -14,6 +14,21 @@
 help_text = _("Limit tag creation to super users, staff or users with a minimum reputation."),
 required=False))
 
+ENFORCE_TAG_FORMAT_FLAG = Setting('ENFORCE_TAG_FORMAT_FLAG', False, FORUM_SET, dict(
+label = _("Enforce tag format"),
+help_text = _("Should question's tags be checked against a regular expression"),
+required=False))
+
+ENFORCE_TAG_FORMAT_RX = Setting('ENFORCE_TAG_FORMAT_RX', '', FORUM_SET, dict(
+label = _("Enforce tag format RX"),
+help_text = _("Regular eXpression which must match at least one tag on the question"),
+required=False))
+
+ENFORCE_TAG_FORMAT_ERROR_MESSAGE = Setting('ENFORCE_TAG_FORMAT_ERROR_MESSAGE', '', FORUM_SET, dict(
+label = _("Enforce tag format error message"),
+help_text = _("Error message to show if the tags from a question fail to meet the above regular expression (can contain HTML)"),
+widget=Textarea(attrs={'rows': '10'}),
+required=False)) 
 
 """ settings for questions """
 FORM_MIN_QUESTION_TITLE = Setting('FORM_MIN_QUESTION_TITLE', 10, FORUM_SET, dict(

forum/settings/static.py

@@ -103,4 +103,9 @@
         label = _("Custom Head"),
         help_text = _("Your custom Head elements."),
         widget=Textarea(attrs={'rows': '25'}),
-        required=False))
+        required=False))
+
+MATHJAX_ENABLED = Setting('MATHJAX_ENABLED', False, HEAD_SET, dict(
+    label = _("Enable LaTeX support"),
+    help_text = _("Enable LaTeX support via MathJax, by loading MathJax javascript"),
+    required=False))

forum/settings/users.py

@@ -48,6 +48,11 @@
 help_text = _("If you check this the user accept rate will be displayed on the user posts."),
 required=False))
 
+USE_USERS_QUESTIONS_FOR_ACCEPT_RATE = Setting('USE_USERS_QUESTIONS_FOR_ACCEPT_RATE', True, USERS_SET, dict(
+label = _("Calculate accept rate SO style"),
+help_text = _("Calculate rate as own questions with accepted answers / own questions"),
+required=False))
+
 FREEZE_ACCEPT_RATE_FOR = Setting('FREEZE_ACCEPT_RATE_FOR',
 ["admin",],
 USERS_SET, dict(
@@ -121,3 +126,17 @@
 choices=GRAVATAR_DEFAULT_CHOICES,
 required=False))
 
+USERS_CAN_GIVEAWAY_KARMA = Setting('USERS_CAN_GIVEAWAY_KARMA', True, USERS_SET, dict(
+label = _("Enable authenticated users to give away karma"),
+help_text = _("Superuser / staff can give karma regardless of this setting"),
+required=False))
+
+USERS_CAN_OPEN_CLOSE_QUESTIONS = Setting('USERS_CAN_OPEN_CLOSE_QUESTIONS', True, USERS_SET, dict(
+label = _("Enable authenticated users open/close questions"),
+help_text = _("Superuser / staff can open/close questions regardless of this setting. Reputation limit is also taken into account."),
+required=False))
+
+USERS_CAN_CHANGE_AUTH_SETTINGS = Setting('USERS_CAN_CHANGE_AUTH_SETTINGS', True, USERS_SET, dict(
+label = _("Enable users to change auth settings"),
+help_text = _("Enable users to access authentication settings (requires server restart to fully take effect)"),
+required=False))

forum/settings/view.py

@@ -57,3 +57,10 @@
 label = _("Limit related tags block"),
 help_text = _("Limit related tags block size in questions list pages. Set to 0 to display all all tags.")))
 
+AUTO_SET_TAG_ON_QUESTION = Setting('AUTO_SET_TAG_ON_QUESTION', False, VIEW_SET, dict(
+label = _("Automatically set tag on questions asked from tag page"), required=False,
+help_text = _("Automatically set the tag on new questions asked from the tag page")))
+
+USE_NOFOLLOW_ON_USER_LINKS = Setting('USE_NOFOLLOW_ON_USER_LINKS', False, VIEW_SET, dict(
+label = _("Set nofollow on links in questions/answers"), required=False,
+help_text = _("Set the nofollow attribute on links in questions/answers (only applies for new/edited questions/answers)")))

forum/sitemap.py

@@ -7,17 +7,14 @@
 from django.http import HttpResponse, Http404
 from django.template import loader
 from django.core import urlresolvers
+from django.core.urlresolvers import get_script_prefix
 from django.utils.encoding import smart_str
 from django.core.paginator import EmptyPage, PageNotAnInteger
 
 def index(request, sitemaps):
     sites = []
-    for section, site in sitemaps.items():
-        if callable(site):
-            pages = site().paginator.num_pages
-        else:
-            pages = site.paginator.num_pages
-        sitemap_url = urlresolvers.reverse('sitemap_section_index', kwargs={'section': section})
+    for section in sitemaps.keys():
+        sitemap_url = urlresolvers.reverse('sitemap_section_index', prefix='/', kwargs={'section': section})
 
         # Replace double forward slashes with single ones
         final_url = '%s%s' % (settings.APP_URL, sitemap_url)
@@ -41,7 +38,7 @@ def sitemap_section_index(request, section, sitemaps):
     locations = []
 
     for page in paginator.page_range:
-        location = urlresolvers.reverse('sitemap_section_page', kwargs={ 'page' : page, 'section' : section })
+        location = urlresolvers.reverse('sitemap_section_page', prefix='/', kwargs={ 'page' : page, 'section' : section })
         location = '%s%s' % (settings.APP_URL, location)
         location = re.sub("/+", "/", location)
         location = location.replace('http:/', 'http://')
@@ -98,7 +95,9 @@ def __get(self, name, obj, default=None):
     def get_urls(self, page=1):
         urls = []
         for item in self.paginator.page(page).object_list:
-            loc = "%s%s" % (settings.APP_URL, self.__get('location', item))
+            root_relative_url = self.__get('location', item)
+            relative_url = root_relative_url[len(get_script_prefix()):]
+            loc = "%s/%s" % (settings.APP_URL, relative_url)
             url_info = {
                 'location':   loc,
                 'lastmod':    self.__get('lastmod', item, None),

forum/skins/default/media/js.src/pagedown/Markdown-combo.js

@@ -2269,6 +2269,7 @@ else
             elapsedTime = currTime - prevTime;
 
             pushPreviewHtml(text);
+            if (MathJax) { MathJax.Hub.Queue(["Typeset",MathJax.Hub]); }
         };
 
         // setTimeout is already used.  Used as an event listener.