Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update newman to 6.0.0 #421

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Conversation

scotty6435
Copy link
Contributor

A proposed change to update to the newman 6.0.0 release as seen in this issue. Users have reported that this tool works just fine, I'm opening this PR in the hopes there is automated builds which will validate this, if not it will need some review from SMEs as I'm not familiar with this library

@DannyDainton
Copy link
Owner

DannyDainton commented Dec 4, 2023

This is only changing a Dev dependency, which is used for the local tests.

The issue you linked shows that the reporter is working with version 6 of Newman.

What testing have you done for this change?

Newman v6 can only run on newer node versions so we would also need to change a few more things, as well as updating the number in that file.

@scotty6435
Copy link
Contributor Author

@DannyDainton I completely understand. I've updated the peer dependency but I'm afraid I'm not familiar at all with this dep - I'm just trying to resolve vulnerabilities being reported by our security software which is unfortunately only available in newman 6.0.0 and not backported to 5.x

@ackermanusaa
Copy link

Also looking for Newman 6.0.0 support

@DannyDainton DannyDainton merged commit c061e48 into DannyDainton:main Dec 22, 2023
2 checks passed
@scotty6435 scotty6435 deleted the newman-upgrade branch March 19, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants