Skip to content

This PR addresses issue #1573 by modifying the GetDeserializer logic to map nullable decimal values to 0m instead of null. #2167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

This PR addresses issue #1573 by modifying the GetDeserializer logic to map nullable decimal values to 0m instead of null. #2167

wants to merge 1 commit into from

Conversation

AlexGreatDev
Copy link

  • Added explicit check for decimal? types in GetDeserializer
  • Returns 0m when encountering a NULL value
  • Maintains existing behavior for other types

Closes #1573

@mgravell
Copy link
Member

Returning zero for null seems ... just wrong; unless I'm mistaken (and that does happen), we don't usually null-coalesce like this; what is the reason / scenario here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Just wonder reason of the casting?
2 participants
@AlexGreatDev @mgravell