Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/scihub 1401 edit mode does not change #91

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

zgrybus
Copy link
Collaborator

@zgrybus zgrybus commented Mar 18, 2024

Changes

Screenshot / Video of the changes

Pre-Merge Checklist

Notifications:

  • Added Reviewers

Documentation:

  • Updated CHANGELOG.
  • Updated version.

Code Quality

  • Added or updated unit tests.

@zgrybus zgrybus added the bug Something isn't working label Mar 18, 2024
@zgrybus zgrybus self-assigned this Mar 18, 2024
Copy link
Collaborator

@mateusz-kleszcz mateusz-kleszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix e2e tests

src/lib/packages/EditorContext/EditorContextProvider.tsx Outdated Show resolved Hide resolved
@zgrybus zgrybus merged commit 4308895 into dev Mar 18, 2024
3 checks passed
@zgrybus zgrybus deleted the bug/SCIHUB-1401-edit-mode-does-not-change branch March 18, 2024 10:37
zgrybus added a commit that referenced this pull request Apr 30, 2024
* Feature/scihub 963 add GitHub workflows (#80)

---------

Co-authored-by: Krzysztof Nofz <[email protected]>

* Feature/scihub 1058 increase modal index (#84)

---------

Co-authored-by: Krzysztof Nofz <[email protected]>

* Feature: scihub-1209 google slide modal (#87)

* feature/SCIHUB-1209: fixed typo in hook name

* feature/SCIHUB-1209 add component prop

* feature/SCIHUB-1209: fixed naming

* feature/SCIHUB-1209: increment version

* feature/SCIHUB-1209: whole modal as prop

---------

Co-authored-by: Krzysztof Nofz <[email protected]>

* Feature/scihub 1247 enable mentioning users (#89)

* feature/SCIHUB-1247 enable mentioning users

---------

Co-authored-by: Krzysztof Nofz <[email protected]>

* Bug/scihub 1401 edit mode does not change (#91)

* bug/SCIHUB-1401 migrate to new milkdown way of handling editable flag

* bug/SCIHUB-1401 updated changelog

* bug/SCIHUB-1401 remove type from useRef

---------

Co-authored-by: Krzysztof Nofz <[email protected]>

* Feature/kap 510 add is dirty (#93)

* feature/KAP-510 add is dirty

* feature/KAP-510 updated changelog

---------

Co-authored-by: Krzysztof Nofz <[email protected]>

* release/0.3.2 updated version

---------

Co-authored-by: Krzysztof Nofz <[email protected]>
Co-authored-by: Mateusz Kleszcz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants