feat: post global chat messages to discord #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: this feature is entirely optional, dotnet6 -> dotnet8
|
According to https://discord.com/safety/using-webhooks-and-embeds webhooks are limited to posting 30 messages a minute.
I guess this might be an issue... |
DarkAtra
commented
Jun 27, 2024
| private static readonly HttpClient _httpClient = new(); | ||
| private static readonly JsonSerializerOptions _serializeOptions = new() { | ||
| DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull, | ||
| PropertyNamingPolicy = JsonNamingPolicy.SnakeCaseLower |
There was a problem hiding this comment.
JsonNamingPolicy.SnakeCaseLower does not exist in .net6 - see https://github.com/DarkAtra/v-rising-discord-bot-companion/pull/24/files#r1657375255
DarkAtra
commented
Jun 27, 2024
| @@ -4,7 +4,7 @@ | |||
| <Description>A companion mod for DarkAtra/v-rising-discord-bot.</Description> | |||
| <Version>0.4.1</Version> | |||
|
|
|||
| <TargetFramework>net6.0</TargetFramework> | |||
| <TargetFramework>net8.0</TargetFramework> | |||
There was a problem hiding this comment.
likely has to be reverted - the game uses .net6 and i'm not sure if using a different .net version would cause unexpected issues, so it's safer to stay on the same version as the game for now.
|
Progress is tracked here: DarkAtra/v-rising-discord-bot#104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows server owners to use a discord webhook to post ingame chat messages (global only) to discord.
See: https://github.com/DarkAtra/v-rising-discord-bot-companion/pull/24/files#diff-5a2f4e90167632d0df9d167fad586935062628fbbe8cb69ac5c0415663fac33aR44-R61