-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Skullcrush instakill hotfix" #1073
Conversation
This reverts commit 1cbecbf.
Why is this revert good? |
We never got the bandaid fix Nick was talking about to make hits after the skullcrush a death blow is perhaps the main reason Unfortunately this brings back the return of stabbing people in the skull to kill them, but it does permit PVE to be much faster paced again |
Theres been a ton of complaints for months about blunt being unable to kill NPCs, this is the obvious culprit given what it touches and the date. Simple as. |
To my understanding stabbing goblins in the heart was the way to go, but indeed other weapon types were not able to kill them. |
I noticed the same with zombies, just mauling their head endlessly with a huge club did nothing, its lame and I suspect this PR is to blame. But it should be obvious what the truth is with some more testing |
Perhaps looking at what causes death() with heartshots against critically weak mobs should be transplanted onto the top-tier-most critical injuries associated with blunt weapons would be a better change instead? I feel like all non-carbon mobs should be critically weak on account of them operating on pointmed, as carbon mobs can collapse from pain or become incapacitated by limb damage (as being rendered into a non-fighting state is the same as killing someone, really), whereas NPC simple mobs can continue attacking until dead. |
I was crushing orbital bones fine during the halloween skeleton siege. It caused skeletons to drop to the ground and stop moving. Perhaps some localtesting should be done to make absolutely sure that this is not working in some way? There is not even an issue open right now detailing the problem. |
#814 is the one issue open. |
Probably not needed then? Possibly? Who knows anything, what is even time. |
Reverts #791
So how about that