Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Skullcrush instakill hotfix" #1073

Closed
wants to merge 1 commit into from
Closed

Conversation

NPC1314
Copy link
Contributor

@NPC1314 NPC1314 commented Nov 7, 2024

Reverts #791

So how about that

@NPC1314 NPC1314 added the Scheduled for testmerge This PR should be testmerged label Nov 7, 2024
@BadAtThisGame302
Copy link
Contributor

Why is this revert good?

@1N7Slayer
Copy link
Contributor

1N7Slayer commented Nov 8, 2024

Why is this revert good?

We never got the bandaid fix Nick was talking about to make hits after the skullcrush a death blow is perhaps the main reason

Unfortunately this brings back the return of stabbing people in the skull to kill them, but it does permit PVE to be much faster paced again

@NPC1314
Copy link
Contributor Author

NPC1314 commented Nov 8, 2024

Theres been a ton of complaints for months about blunt being unable to kill NPCs, this is the obvious culprit given what it touches and the date.
If goblins etc dies now as they should, then this revert gets merged. (depending on how cancer the stab death thing is ofc)
If it does not help, it not getting merged.

Simple as.

@1N7Slayer
Copy link
Contributor

Theres been a ton of complaints for months about blunt being unable to kill NPCs, this is the obvious culprit given what it touches and the date. If goblins etc dies now as they should, then this revert gets merged. If it does not help, it not getting merged.

Simple as.

To my understanding stabbing goblins in the heart was the way to go, but indeed other weapon types were not able to kill them.

@NPC1314
Copy link
Contributor Author

NPC1314 commented Nov 8, 2024

Theres been a ton of complaints for months about blunt being unable to kill NPCs, this is the obvious culprit given what it touches and the date. If goblins etc dies now as they should, then this revert gets merged. If it does not help, it not getting merged.
Simple as.

To my understanding stabbing goblins in the heart was the way to go, but indeed other weapon types were not able to kill them.

I noticed the same with zombies, just mauling their head endlessly with a huge club did nothing, its lame and I suspect this PR is to blame. But it should be obvious what the truth is with some more testing

@1N7Slayer
Copy link
Contributor

1N7Slayer commented Nov 8, 2024

Theres been a ton of complaints for months about blunt being unable to kill NPCs, this is the obvious culprit given what it touches and the date. If goblins etc dies now as they should, then this revert gets merged. If it does not help, it not getting merged.
Simple as.

To my understanding stabbing goblins in the heart was the way to go, but indeed other weapon types were not able to kill them.

I noticed the same with zombies, just mauling their head endlessly with a huge club did nothing, its lame and I suspect this PR is to blame. But it should be obvious what the truth is with some more testing

Perhaps looking at what causes death() with heartshots against critically weak mobs should be transplanted onto the top-tier-most critical injuries associated with blunt weapons would be a better change instead? I feel like all non-carbon mobs should be critically weak on account of them operating on pointmed, as carbon mobs can collapse from pain or become incapacitated by limb damage (as being rendered into a non-fighting state is the same as killing someone, really), whereas NPC simple mobs can continue attacking until dead.

@anything86
Copy link
Contributor

anything86 commented Nov 8, 2024

I was crushing orbital bones fine during the halloween skeleton siege. It caused skeletons to drop to the ground and stop moving. Perhaps some localtesting should be done to make absolutely sure that this is not working in some way? There is not even an issue open right now detailing the problem.

@NPC1314
Copy link
Contributor Author

NPC1314 commented Nov 8, 2024

I was crushing orbital bones fine during the halloween skeleton siege. It caused skeletons to drop to the ground and stop moving. Perhaps some localtesting should be done to make absolutely sure that this is not working in some way? There is not even an issue open right now detailing the problem.

#814 is the one issue open.
Theres rarely issues opened, like 95% of bugs never get there. Its mostly fumbling in the dark with no input.
Theres almost no documentation whether 791 actually did a damn thing or not, as with most things.
I urge anyone who wants to test out things and type up a update on PRs or issues of this type to do so, it helps immensly.

@NPC1314
Copy link
Contributor Author

NPC1314 commented Nov 8, 2024

Probably not needed then? Possibly? Who knows anything, what is even time.

@NPC1314 NPC1314 closed this Nov 8, 2024
@NPC1314 NPC1314 removed the Scheduled for testmerge This PR should be testmerged label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants