Necromancer from Blackstone

[Valkrae]

About The Pull Request

• Adds Necromancer as a selectable role. They are disguised as baseline Mages/Sorceresses.
• Necromancers have four spells to choose from.
• Bone Chill - It heals undead mobs, and it damages non-undead. Non-undead mobs are also paralyzed for a time. The time has been halved from what the value was on Blackstone. This can and will be changed if it proves to be problematic.
• Eyebite - Blinds the target for a small period, and floods the target with negative energy, dealing a significant amount of damage.
• Raise Undead - Summons a skeleton simplemob. Currently, they are spawned with basic peasant equivalent gear and stats. They do not attack the Necromancer, or other deadites.
• Ray of Sickness - Floods the target with toxins. Will eventually make you vomit, and be stunned.
• The current only goal of the Necromancer is to survive until the end of the week.

Why It's Good For The Game

This PR is my attempt at a port and re-balancing of the Blackstone Necromancer. I admit that the "balance" has been minimal, but I'd like to see how it performs ingame through a testmerge and feedback, similar to how Assassin was handled. I've tested extensively on a localhost, and there are no extreme errors of which I am aware.

Pre-Merge Checklist

• You tested this on a local server.
• This code did not runtime during testing.
• You documented all of your changes.

[InsightfulParasite]

Does it eventually die or is it permanent?

[Valkrae]

permanent, its a simplemob.

[Valkrae]

i mean, if you beat it to death, it'll be dead, if that's what you're asking. but no, there's no timer that annihilates it from existence after a set period of time.

[sanshoom]

Necromancers after I use Churn Undead

[ThePainkiller]

Copypasting is bad.....at least remember to rename datums....

[Valkrae]

thanks, im stupid!

[Valkrae]

added some misc. fixes that were mentioned in discord

[ThePainkiller]

Since you added the proc on after_spawn I think this would be unnecessary, as you just do ADD_TRAIT(H, TRAIT_NECROMANCER) here instead, and it would automatically assign it the necromancer antag datum on after_spawn after it checks for this perk, which...you forgot to assign here on his own DM....

[Valkrae]

so, what you're saying is I should add the perk, and remove the var/datum/antagonist/new_antag = new /datum/antagonist/necromancer() ?

sorry, this is my first actual PR that has more than 2 things changed, so im a little slow on the uptick.

[ThePainkiller]

I'll explain it the best I can:

On DRIFTERZ.dm, on the after_spawn() proc for drifters, you added a check: If the drifter has the trait TRAIT_NECROMANCER, assign to them the Necromancer antag datum (turn them into a Necromancer antag). Like so:

if(!H.mind)
	if(HAS_TRAIT(H, TRAIT_NECROMANCER)) // if the mob is a necromancer, they will be given the necromancer antag (i want to enact pain on this antag)
		var/datum/antagonist/new_antag = new /datum/antagonist/necromancer()
		H.mind.add_antag_datum(new_antag)

Here, you forced the Necromancer antag datum on the proc that equips all skills and changes stats when choosing a necromancer, basically copypasting the above proc (and forgot to assign the trait TRAIT_NECROMANCER to them) so the trait is literally unused, and the proc on after_spawn() never succeeds.

You gotta pick the method to assign antag datum, one or the other. Mind that if you copypasted Assassin, this was made so that admins could turn people into Assassins mid-round as an antag (which would also be good for Necromancer to have)

This can lead to conflicts as the Necromancer antag datum would be applied twice in immediate succession, had you not forgotten to include the ADD_TRAIT(H, TRAIT_NECROMANCER) to this line I'm quoting.

So the TL;DR is, yes, please replace these two lines:

var/datum/antagonist/new_antag = new /datum/antagonist/necromancer() // Adds the necromancer antag label.
H.mind.add_antag_datum(new_antag)

With just:
ADD_TRAIT(H, TRAIT_NECROMANCER)

[Valkrae]

thank you, ill go ahead and do that!

[Cre77]

how about adding friendly examine text, so that player zombies and skeletons (maybe even vampires?) know this is a necromancer at a glance, and vice versa? like what /datum/antagonist/zombie/examine_friendorfoe(datum/antagonist/examined_datum,mob/examiner,mob/examined does in zomble[sic].dm

[Stutternov]

Was this tested so it can go live?

[Valkrae]

Was this tested so it can go live?

I've tested it extensively in SP, but what I need to do now is see how it functions balance-wise in the larger server environment.

[DovaKitty]

Looks good for testmerge. I'd like to see player reviews on the balance of the spells ingame.

[DovaKitty]

Should be TM'd. Will need to see balance of the added spells, especially eyebite, which can paralyze.

[ThePainkiller]

Once merge conflicts are solved, we will TM to test it in live, really excited about this one

[YuiY1997]

Has anybody DMed whoever this is on discord to tell them to resolve conflicts?

[ThePainkiller]

Being addressed by the coder team, Rebel will try to force push things here, or we might close it and one of us will re-open it up to date

[Stutternov]

I'll see about force pushing this code tomorrow to get this working.

[BadAtThisGame302]

Two weeks ago last change, seems very stale and unworked on to me.... it's a big shame, really.

[ThePainkiller]

Is this still being worked on or can we shelve it for stale?

[NPC1314]

Staler than bread packed in your spare bag and forgotten after that one trip to the lake, only to be found the next summer.