Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hats file finish #792

Merged
merged 12 commits into from
Sep 30, 2024
Merged

Hats file finish #792

merged 12 commits into from
Sep 30, 2024

Conversation

NPC1314
Copy link
Contributor

@NPC1314 NPC1314 commented Sep 25, 2024

About The Pull Request

Wraps up the hats.dm structure & cleaning of depreceated content
Adds the new value defines to determine sell prices and values
Arming cap gets a little padding, its by definition a padded hood worn under coifs and such

Order is good and lets you overview what stats items have and future ones should have. Having a system for values is good.
The file diff isn't very useful, just open the file and witness the order.

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

@NPC1314 NPC1314 added the Merge conflict This PR won't compile due to merge conflics label Sep 26, 2024
@NPC1314 NPC1314 removed the Merge conflict This PR won't compile due to merge conflics label Sep 29, 2024
@NPC1314 NPC1314 added the Scheduled for testmerge This PR should be testmerged label Sep 29, 2024
@NPC1314
Copy link
Contributor Author

NPC1314 commented Sep 29, 2024

Everything checks out, safe to merge

Copy link
Contributor

@ThePainkiller ThePainkiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love defines, I love premade lists, this standardization is gonna be fucking QOL GOLD for us.

@ThePainkiller ThePainkiller merged commit 4846b71 into Darkrp-community:main Sep 30, 2024
3 checks passed
@NPC1314 NPC1314 removed the Scheduled for testmerge This PR should be testmerged label Sep 30, 2024
@NPC1314 NPC1314 deleted the headfinish branch October 9, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants