Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/4561 #4661

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Fix/4561 #4661

merged 4 commits into from
Jan 21, 2025

Conversation

dsilhavy
Copy link
Collaborator

This PR addresses #4561.

  • Adds a new setting deleteEventMessageDataAfterEventStarted set to true by default. If this flag is enabled, the EventController will delete the messageData and the parsedMessageData of events after they have been started. This is to save memory in case events have a long duration and need to be persisted in the EventController for a while to not be retriggered.
  • Note: Applications will receive a copy of the original event data when they subscribe to an event. This copy contains the original message data and is not affected by deleteEventMessageDataAfterEventStarted. Only if an event is dispatched for the second time (e.g. when the user seeks back) the message data will not be included in the dispatched event. In this case, the app would need to persist the messageData if required.

I am open for feedback on this one. As an alternative, we could also define an eventMessagePersistDuration after which we delete the payload.

In any case, we need to find a solution for events that have a long duration, as outlined in #4561.

@dsilhavy dsilhavy merged commit 996f57a into development Jan 21, 2025
3 checks passed
@dsilhavy dsilhavy deleted the fix/4561 branch January 21, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant