CMAF Ingest Content-Length #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvkhoi112358
approved these changes
Jan 13, 2025
cmd/livesim2/app/cmaf-ingester.go
Outdated
| default: | ||
| slog.Warn("unknown content type", "type", contentType) | ||
| } | ||
| setIngestHeader(req) |
There was a problem hiding this comment.
This is a bit out of topic, but value of Dash-If-Ingest is 1.1.
I thought it should be 1.6?
There was a problem hiding this comment.
@nvkhoi112358 Yes, the version is not the latest, but I think it should be 1.2, not 1.6
Where did you see 1.6?
There was a problem hiding this comment.
Ah, sorry, I thought it would be the version of livesim2.
There was a problem hiding this comment.
It's a good idea to add the livesim2 version as well. Will do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMAF Ingest PUT of segments now use content-length, unless chunk duration is specified, in which case segments are pushed chunk by chunk as produced.
This solves #242.