Add support for checking if power LED lit up on APU platforms #695
Conversation
filipleple
force-pushed
the
apu-check-led
branch
from
4f2695b to
6eb3d7b
Compare
keywords.robot
Outdated
| FOR ${i} IN RANGE 5 | ||
| ${out}= Rte Check Power Led | ||
| IF '${out}' == 'high' RETURN | ||
| Sleep 1s |
There was a problem hiding this comment.
1s seems very long. On some faster platforms it may result in losing the prompt. Do we have any estimated interval of polling the GPIOs with the API which will be safe?
There was a problem hiding this comment.
Changed the polling rate. I've estimated that 0.25 seems optimal - 0.1 already causes a too many requests crash
| @@ -29,6 +29,7 @@ ${INTERNAL_PROGRAMMER_CHIPNAME}= "Opaque flash chip" | |||
| ${FLASHING_METHOD}= external | |||
| ${SNIPEIT}= yes | |||
| ${SEABIOS_BOOT_DEVICE}= ${EMPTY} | |||
| ${CHECK_POWER_LED_SUPPORT}= ${FALSE} | |||
There was a problem hiding this comment.
Aren't there more platform which support LED, than those which don't?
It would be good to enforce the support and disable it just as an exception for platform, where it is not possible.
There was a problem hiding this comment.
Inverted the support logic
| ${BIOS_LIB}= seabios | ||
| ${FW_STRING}= F10 | ||
| ${SEABIOS_BOOT_DEVICE}= 4 |
There was a problem hiding this comment.
Hmm. We also have UEFI variant of the firmware. How will we deal with it? IS there a separate PC Engines config for UEFI variant?
| @@ -22,7 +22,7 @@ MarkupSafe==2.1.5 | |||
| mdurl==0.1.2 | |||
| nodeenv==1.8.0 | |||
| oauth2client==4.1.3 | |||
| osfv @ git+https://github.com/Dasharo/osfv-scripts.git@36a030eb006391c3761c25d6972036a5a34fb73b#subdirectory=osfv_cli | |||
| osfv @ git+https://github.com/Dasharo/osfv-scripts.git@solve-pwon#subdirectory=osfv_cli | |||
There was a problem hiding this comment.
Just leaving it as a comment, so we won't forget.
This has to be an exact SHA1 revision in the final PR form.
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
filipleple
force-pushed
the
apu-check-led
branch
from
6eb3d7b to
6253d9d
Compare
No description provided.