Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build FANS as a library to be coupled to a macro-scale simulation via preCICE and the Micro Manager #23

Merged
merged 136 commits into from
Nov 4, 2024

Conversation

IshaanDesai
Copy link
Collaborator

@IshaanDesai IshaanDesai commented Sep 21, 2024

In a multiscale simulation, FANS would be coupled to a macro-scale simulation. This coupling will be done using preCICE and the Micro Manager. For such a coupling, FANS needs to be compiled as a library with a pre-defined API. This API is described in https://precice.org/tooling-micro-manager-prepare-micro-simulation.html

This PR adds functionality for FANS to be coupled as a library. The original contribution is done by @tjwsch.

siggmo added 30 commits June 26, 2024 18:54
…uces size from 495MB to 161MB). Also add dev deps to dev package explicitly. And update docker.yaml workflow
…t's not supported there and erraneously add include paths called COMPONENT
@IshaanDesai IshaanDesai marked this pull request as ready for review October 31, 2024 13:06
@sanathkeshav sanathkeshav requested a review from juliusgh October 31, 2024 13:25
@IshaanDesai IshaanDesai requested a review from siggmo October 31, 2024 14:16
Copy link
Collaborator

@siggmo siggmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor improvements regarding CMake.

pyfans/CMakeLists.txt Outdated Show resolved Hide resolved
pyfans/CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
.github/workflows/test_pyfans.yaml Show resolved Hide resolved
pyfans/README.md Outdated Show resolved Hide resolved
Copy link
Member

@juliusgh juliusgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have suggested some changes regarding the interaction with the FANS solver and usability.

pyfans/micro.cpp Outdated Show resolved Hide resolved
pyfans/micro.cpp Show resolved Hide resolved
pyfans/micro.cpp Show resolved Hide resolved
pyfans/micro.cpp Show resolved Hide resolved
pyfans/micro.cpp Show resolved Hide resolved
pyfans/micro.hpp Outdated Show resolved Hide resolved
Copy link
Member

@juliusgh juliusgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pyfans/micro.hpp Outdated Show resolved Hide resolved
pyfans/micro.hpp Outdated Show resolved Hide resolved
pyfans/micro.hpp Outdated Show resolved Hide resolved
.github/workflows/test_pyfans.yaml Outdated Show resolved Hide resolved
Copy link
Member

@sanathkeshav sanathkeshav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IshaanDesai IshaanDesai merged commit e185190 into develop Nov 4, 2024
8 checks passed
@IshaanDesai IshaanDesai deleted the lib_micro_sim branch November 4, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants