-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build FANS as a library to be coupled to a macro-scale simulation via preCICE and the Micro Manager #23
Conversation
…ommand for GNU math lib
ignore before)
…tained FANS container
…n and update readme accordingly.
…uces size from 495MB to 161MB). Also add dev deps to dev package explicitly. And update docker.yaml workflow
…i-bin to runtime deps
…cmake in install step
…t's not supported there and erraneously add include paths called COMPONENT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor improvements regarding CMake.
Co-authored-by: Moritz Sigg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have suggested some changes regarding the interaction with the FANS solver and usability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In a multiscale simulation, FANS would be coupled to a macro-scale simulation. This coupling will be done using preCICE and the Micro Manager. For such a coupling, FANS needs to be compiled as a library with a pre-defined API. This API is described in https://precice.org/tooling-micro-manager-prepare-micro-simulation.html
This PR adds functionality for FANS to be coupled as a library. The original contribution is done by @tjwsch.