Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work out a better way to do WDL conditionals #4550

Open
adamnovak opened this issue Jul 27, 2023 · 0 comments
Open

Work out a better way to do WDL conditionals #4550

adamnovak opened this issue Jul 27, 2023 · 0 comments
Labels

Comments

@adamnovak
Copy link
Member

adamnovak commented Jul 27, 2023

We would like the decision of which branch of a WDL conditional to run to depend only on the condition expression, and the jobs in the body to depend only on their own inputs.

But right now, we have WDL conditionals as a whole depend on what their body jobs might access. So even if we know the condition is false early on, the conditional and anything that depends on it will have to wait for everything it would have used if it were true.

I don't think we can really fix this unless we add a way for jobs that already exist to get new follow-on-of relationships after being created. The jobs downstream of the conditional need to wait for the jobs upstream of the conditional's body only if the condition happens to be true. If we find that the condition is false we want to be able to run them in parallel. If the jobs involved already exist before the condition gets evaluated, we need a way to create (or destroy?) the predecessor links.

Alternatively, we could defer creating any of the jobs downstream of a conditional until we know if the condition is true or false.

Originally posted by @DailyDreaming in https://github.com/DataBiosphere/toil/pull/4524#discussion_r1273119966

┆Issue is synchronized with this Jira Story
┆Issue Number: TOIL-1380

@unito-bot unito-bot added the wdl label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants