Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress Slurm job listing and polling output from debug logs #4493

Merged

Conversation

adamnovak
Copy link
Member

This will fix #4478 by making the Slurm batch system more quiet at debug level. We haven't had many problems with parsing Slurm's output; this should make the debug logs easier to scan for the sorts of problems we have actually been having.

Changelog Entry

To be copied to the draft changelog by merger:

  • Slurm batch system no longer logs job listing/polling command output even with --logDebug, because there is a lot of it.

Reviewer Checklist

  • Make sure it is coming from issues/XXXX-fix-the-thing in the Toil repo, or from an external repo.
    • If it is coming from an external repo, make sure to pull it in for CI with:
      contrib/admin/test-pr otheruser theirbranchname issues/XXXX-fix-the-thing
      
    • If there is no associated issue, create one.
  • Read through the code changes. Make sure that it doesn't have:
    • Addition of trailing whitespace.
    • New variable or member names in camelCase that want to be in snake_case.
    • New functions without type hints.
    • New functions or classes without informative docstrings.
    • Changes to semantics not reflected in the relevant docstrings.
    • New or changed command line options for Toil workflows that are not reflected in docs/running/{cliOptions,cwl,wdl}.rst
    • New features without tests.
  • Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
  • Finish the review with an overall description of your opinion.

Merger Checklist

  • Make sure the PR passes tests.
  • Make sure the PR has been reviewed since its last modification. If not, review it.
  • Merge with the Github "Squash and merge" feature.
    • If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
  • Copy its recommended changelog entry to the Draft Changelog.
  • Append the issue number in parentheses to the changelog entry.

@adamnovak adamnovak changed the title Suppress Slurm job listing and polling output form debug logs Suppress Slurm job listing and polling output from debug logs Jun 1, 2023
Copy link
Member

@DailyDreaming DailyDreaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DailyDreaming DailyDreaming merged commit 62ab689 into DataBiosphere:master Jun 13, 2023
@adamnovak
Copy link
Member Author

It looks like this appeared to pass CI, but did not actually pass CI, because Gitlab CI never told Github it was running on this.

I think this added a bug that fails Gitlab CI and is upsetting #4499.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug logs from Slurm runs are too noisy because they dump full command output
2 participants