Restore topolvm support #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaymat
approved these changes
Jun 6, 2024
Rename the storage class from `topolvm-provisioner` to `dynamic-local-data` in order to provider a better user experience. Users don't need to know that the storage class is using topolvm underneath but they are interested in knowing what kind of volumes will be provisioned.
We don't plan on supporting openEBS in our clusters in the foreseable future so let's drop the code to autoscale nodes base on it for now.
Fricounet
force-pushed
the
fricounet/topolvm-support
branch
from
1bdb3c0
to
db15117
Compare
bpineau
approved these changes
Jun 10, 2024
Running TopoLVM for local persistent-data like we do with the local volume provisioner will be a pain in terms of scheduling (how to make sure a pod using shared local data on a node can always come back on it). As a result, we will keep the current setup with the local volume provisioner for persistent storage while we leverage TopoLVM for ephemeral storage on the node. This way, we won't have to deal with TopoLVM scheduling issues.
bpineau
approved these changes
Jun 18, 2024
Explicitely do not trigger a scale up if we request a persistent topolvm volume (or an ephemeral local data volume)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds back a previous commit (added in #52) that is needed to provide proper support for topolvm scaling in the autoscaler. This will allow the autoscaler to scale nodegroups having local data when a pod requests some.
This also rename the topolvm storage class from
topolvm-provisionertodynamic-local-datato provide a better UX by being more descriptive on what kind of volume the user can expect.