Collect PodDisruptionBudgets in Cluster Agent #30412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jbartosik
force-pushed
the
joachim-bartosik-add-pdb-01
branch
3 times, most recently
from
44691d6 to
dc89011
Compare
rtrieu
requested changes
Oct 23, 2024
releasenotes/notes/cluster-agent-collect-pod-disruption-budget-5d8cf316c3633684.yaml
Outdated
Show resolved
Hide resolved
jbartosik
force-pushed
the
joachim-bartosik-add-pdb-01
branch
4 times, most recently
from
1162e01 to
aca050e
Compare
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=48142890 --os-family=ubuntuNote: This applies to commit 063f429 |
fisherevans
approved these changes
Oct 23, 2024
aureleoules
reviewed
Oct 23, 2024
pkg/collector/corechecks/cluster/orchestrator/collectors/k8s/poddisruptionbudget.go
Outdated
Show resolved
Hide resolved
jbartosik
force-pushed
the
joachim-bartosik-add-pdb-01
branch
from
aca050e to
3882e2f
Compare
Regression Detector |
jbartosik
force-pushed
the
joachim-bartosik-add-pdb-01
branch
from
3882e2f to
820ab55
Compare
jbartosik
force-pushed
the
joachim-bartosik-add-pdb-01
branch
from
820ab55 to
121d517
Compare
rtrieu
approved these changes
Oct 30, 2024
NOTE: not adding yaml - all the yaml fields are marked as obsolete and we now have a dedicated pipeline for yamls so I presume there is no need to add the field
jbartosik
force-pushed
the
joachim-bartosik-add-pdb-01
branch
from
121d517 to
2bcb7f7
Compare
jbartosik
force-pushed
the
joachim-bartosik-add-pdb-01
branch
from
2bcb7f7 to
063f429
Compare
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Collect PodDisruptionBudgets in Cluster Agent.
Motivation
Collect PDB information.
Describe how to test/QA your changes
Tested locally:
The agent reports observing the PDB, doesn't crash.
TDB: verify no change in CPU load.
Possible Drawbacks / Trade-offs
Additional Notes
Needs DataDog/agent-payload#351 to be submitted and pulled in properly before this can be submitted.