-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[USM] Introduce tail cals for the Postgres monitoring #30547
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitslavin
added
qa/done
QA done before merge and regressions are covered by tests
team/usm
The USM team
changelog/no-changelog
labels
Oct 28, 2024
guyarb
reviewed
Oct 29, 2024
guyarb
reviewed
Oct 29, 2024
guyarb
reviewed
Oct 29, 2024
guyarb
reviewed
Oct 29, 2024
guyarb
reviewed
Oct 29, 2024
guyarb
reviewed
Oct 29, 2024
guyarb
reviewed
Oct 29, 2024
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=48129003 --os-family=ubuntu Note: This applies to commit 3d8e492 |
Regression Detector |
guyarb
requested changes
Oct 30, 2024
github-actions
bot
added
long review
PR is complex, plan time to review it
and removed
medium review
PR review might take time
labels
Oct 30, 2024
amitslavin
changed the title
[USMO] Introduce tail cals for the Postgres monitoring
[USM] Introduce tail cals for the Postgres monitoring
Nov 3, 2024
guyarb
reviewed
Nov 3, 2024
guyarb
reviewed
Nov 3, 2024
guyarb
reviewed
Nov 3, 2024
guyarb
reviewed
Nov 3, 2024
guyarb
reviewed
Nov 3, 2024
guyarb
reviewed
Nov 3, 2024
guyarb
reviewed
Nov 3, 2024
guyarb
reviewed
Nov 3, 2024
guyarb
reviewed
Nov 3, 2024
guyarb
reviewed
Nov 3, 2024
guyarb
approved these changes
Nov 4, 2024
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog/no-changelog
component/system-probe
long review
PR is complex, plan time to review it
qa/done
QA done before merge and regressions are covered by tests
team/usm
The USM team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduce the use of tail calls when parsing Postgres messages in both plain text and TLS modes.
Motivation
Reduce the Postgres support interaction count and complexity limits to allow for additional logic, which is currently blocked due to reaching instruction and complexity limits.
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes
TODO:
Results: