Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set another endpoint to forward logs to DDDev #30604

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

KevinFairise2
Copy link
Member

What does this PR do?

Logs cannot be sent to the app.datadoghq.com endpoint, app.datadoghq.com/api/v2/logs sends a 404 error. Instead we need to forward the logs to http-agent-intake.logs.datadoghq.com. This PR update forwarding to forward calls to /api/v2/logs to the correct endpoint.

Motivation

Make sure the payload forwarding works with logs

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@KevinFairise2 KevinFairise2 requested review from a team as code owners October 30, 2024 13:12
@github-actions github-actions bot added team/agent-devx-loops short review PR is simple enough to be reviewed quickly labels Oct 30, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Oct 30, 2024

[Fast Unit Tests Report]

On pipeline 48238547 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Oct 30, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=48238547 --os-family=ubuntu

Note: This applies to commit 957eb77

Copy link

cit-pr-commenter bot commented Oct 30, 2024

Regression Detector

@KevinFairise2 KevinFairise2 added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Oct 30, 2024
Copy link
Contributor

@pducolin pducolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, a couple of comments to add documentation in code and handle v1 endpoint

test/fakeintake/server/server.go Show resolved Hide resolved
test/fakeintake/server/server.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Nov 5, 2024
@KevinFairise2
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 5, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit d533cc2 into main Nov 5, 2024
206 checks passed
@dd-mergequeue dd-mergequeue bot deleted the kfairise/fix-logs-forwarding branch November 5, 2024 12:49
@github-actions github-actions bot added this to the 7.61.0 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-devx-loops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants