-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set another endpoint to forward logs to DDDev #30604
Conversation
[Fast Unit Tests Report] On pipeline 48238547 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=48238547 --os-family=ubuntu Note: This applies to commit 957eb77 |
Regression Detector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, a couple of comments to add documentation in code and handle v1 endpoint
Co-authored-by: pducolin <[email protected]>
Co-authored-by: pducolin <[email protected]>
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Logs cannot be sent to the
app.datadoghq.com
endpoint,app.datadoghq.com/api/v2/logs
sends a404
error. Instead we need to forward the logs tohttp-agent-intake.logs.datadoghq.com
. This PR update forwarding to forward calls to/api/v2/logs
to the correct endpoint.Motivation
Make sure the payload forwarding works with logs
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes