[OTEL-2239] Convert comp/serializer/compression into new style components #30688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team/agent-metrics-logs
long review
Go Package Import DifferencesBaseline: 04a7d9a
|
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=49997882 --os-family=ubuntuNote: This applies to commit 3001ee4 |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 04a7d9a Optimization Goals: ❌ Significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ❌ | basic_py_check | % cpu utilization | +8.82 | [+4.76, +12.87] | 1 | Logs |
| ➖ | pycheck_lots_of_tags | % cpu utilization | +1.80 | [-1.66, +5.27] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.02 | [+0.29, +1.75] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.85 | [+0.06, +1.64] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.26 | [+0.13, +0.40] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.18 | [-0.58, +0.94] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.10, +0.12] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.00 | [-0.71, +0.70] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | -0.00 | [-0.64, +0.63] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.01 | [-0.78, +0.76] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.01 | [-0.48, +0.45] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.17 | [-0.22, -0.11] | 1 | Logs bounds checks dashboard |
| ➖ | otel_to_otel_logs | ingress throughput | -0.58 | [-1.28, +0.11] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.74 | [-0.90, -0.59] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -1.32 | [-1.37, -1.26] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
|
Could we remove the component from the TODO list of components to migrate? datadog-agent/tasks/components.py Line 146 in d838cbd |
|
jackgopack4
approved these changes
Nov 21, 2024
ogaca-dd
approved these changes
Nov 21, 2024
I believe shortly OTel will be looking to incorporate the Native Go zstd implementation to use instead of the cgo one. When that happens I imagine those build tags would be obsolete and we should probably just have something like |
|
📥 📢 Info, this pull request increases the binary size of serverless extension by -8288 bytes. Each MB of binary size increase means about 10ms of additional cold start time, so this pull request would increase cold start time by 0ms. Debug infoIf you have questions, we are happy to help, come visit us in the #serverless slack channel and provide a link to this comment. We suggest you consider adding the |
clarkb7
approved these changes
Nov 25, 2024
gabedos
approved these changes
Nov 25, 2024
purple4reina
approved these changes
Nov 25, 2024
FlorianVeaux
approved these changes
Nov 26, 2024
NouemanKHAL
approved these changes
Nov 26, 2024
Serverless Benchmark Results
tl;drUse these benchmarks as an insight tool during development.
What is this benchmarking?The The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type. How do I interpret these charts?The charts below comes from The benchstat docs explain how to interpret these charts.
I need more helpFirst off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development. If you would like a hand interpreting the results come chat with us in Benchmark stats |
|
/merge |
Devflow running:
|
ankitpatel96
added
the
qa/done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR modifies comp/serializer/compression into the new "component" style https://datadoghq.dev/datadog-agent/components/overview/. One kind of odd thing it does is creates a
selectorpackage - this package contains build time flags to select which implementation to use based on build tags. This is existing logic that I just ported over - I am not trying to change the behavior of anything.Motivation
We want to split up this package so we can pull in different implementations to avoid cgo dependencies in other packages.
Describe how to test/QA your changes
Unit tests continue to pass