Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add dependencies to the internal_kubernetes_deploy_experimental job (#30595)" #30694

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Nov 4, 2024

This reverts commit 4991a56.

What does this PR do?

Motivation

The original PR uncovered issues with the windows job and it prevents us from deploying the beta build. Reverting it until we fix the windows job

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@FlorentClarret FlorentClarret requested a review from a team as a code owner November 4, 2024 09:44
@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly team/agent-delivery labels Nov 4, 2024
@FlorentClarret
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 4, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@FlorentClarret FlorentClarret added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Nov 4, 2024
@agent-platform-auto-pr
Copy link
Contributor

Gitlab CI Configuration Changes

Modified Jobs

internal_kubernetes_deploy_experimental
  internal_kubernetes_deploy_experimental:
    image: 486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent-buildimages/deb_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
    needs:
    - artifacts: false
      job: docker_trigger_internal
    - artifacts: false
      job: docker_trigger_internal-ot
    - artifacts: false
      job: docker_trigger_cluster_agent_internal
-   - artifacts: false
-     job: deploy_packages_windows-x64-7
    - artifacts: false
      job: k8s-e2e-main
      optional: true
    rules:
    - if: $FORCE_K8S_DEPLOYMENT == "true"
      when: always
    - if: $CI_COMMIT_BRANCH != "main"
      when: never
    - if: $DDR != "true"
      when: never
    - if: $APPS !~ "/^datadog-agent/"
      when: never
    - if: $DEPLOY_AGENT == "true" || $DDR_WORKFLOW_ID != null
    script:
    - GITLAB_TOKEN=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $GITLAB_TOKEN write_api)
      || exit $?; export GITLAB_TOKEN
    - inv pipeline.trigger-child-pipeline --project-name DataDog/k8s-datadog-agent-ops
      --git-ref main --variable OPTION_AUTOMATIC_ROLLOUT --variable EXPLICIT_WORKFLOWS
      --variable OPTION_PRE_SCRIPT --variable SKIP_PLAN_CHECK --variable APPS --variable
      BAZEL_TARGET --variable DDR --variable DDR_WORKFLOW_ID --variable TARGET_ENV --variable
      DYNAMIC_BUILD_RENDER_TARGET_FORWARD_PARAMETERS --variable BUNDLE_VERSION_OVERRIDE
    stage: internal_kubernetes_deploy
    tags:
    - arch:amd64
    variables:
      BUNDLE_VERSION_OVERRIDE: v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}
      EXPLICIT_WORKFLOWS: //workflows:beta_builds.agents_nightly.staging-deploy.publish,//workflows:beta_builds.agents_nightly.staging-validate.publish,//workflows:beta_builds.agents_nightly.prod-wait-business-hours.publish,//workflows:beta_builds.agents_nightly.prod-deploy.publish,//workflows:beta_builds.agents_nightly.prod-validate.publish,//workflows:beta_builds.agents_nightly.publish-image-confirmation.publish
      OPTION_AUTOMATIC_ROLLOUT: 'true'
      OPTION_PRE_SCRIPT: patch-cluster-images-operator.sh env=ci ${CI_COMMIT_REF_SLUG}-ot-beta-jmx-${CI_COMMIT_SHORT_SHA}
        ${CI_COMMIT_REF_SLUG}-${CI_COMMIT_SHORT_SHA}
      SKIP_PLAN_CHECK: 'true'

Changes Summary

Removed Modified Added Renamed
0 1 0 0

ℹ️ Diff available in the job log.

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 48134655 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@dd-devflow
Copy link

dd-devflow bot commented Nov 4, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit adec12a into main Nov 4, 2024
228 of 233 checks passed
@dd-mergequeue dd-mergequeue bot deleted the florentclarret/revert-needs branch November 4, 2024 10:50
@github-actions github-actions bot added this to the 7.61.0 milestone Nov 4, 2024
Copy link

Regression Detector

Regression Detector Results

Run ID: d09c73d9-c74a-4e63-bdea-fbd6a9c89c0c Metrics dashboard Target profiles

Baseline: 9722934
Comparison: cf7c86e

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +0.98 [+0.24, +1.72] 1 Logs
idle_all_features memory utilization +0.71 [+0.62, +0.81] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.59 [+0.53, +0.65] 1 Logs
otel_to_otel_logs ingress throughput +0.26 [-0.54, +1.06] 1 Logs
basic_py_check % cpu utilization +0.21 [-2.60, +3.03] 1 Logs
idle memory utilization +0.17 [+0.12, +0.22] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.14 [-0.10, +0.38] 1 Logs
pycheck_lots_of_tags % cpu utilization +0.12 [-2.39, +2.63] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.04 [-0.44, +0.52] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.00 [-0.18, +0.18] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.07, +0.07] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.33, +0.32] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.24, +0.22] 1 Logs
file_tree memory utilization -0.23 [-0.36, -0.10] 1 Logs
quality_gate_idle memory utilization -0.40 [-0.45, -0.36] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.59 [-0.69, -0.49] 1 Logs bounds checks dashboard

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 9/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle_all_features memory_usage 10/10
quality_gate_idle memory_usage 10/10
quality_gate_idle_all_features memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

FlorentClarret added a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants