Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JOBOWNERS to assign image build, publish, and scan jobs to agent-delivery team #30860

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

spencergilbert
Copy link
Contributor

@spencergilbert spencergilbert commented Nov 7, 2024

The Agent Delivery team has taken ownership of the image build and release workflows, including internal deployments.

@spencergilbert spencergilbert self-assigned this Nov 7, 2024
@spencergilbert spencergilbert requested a review from a team as a code owner November 7, 2024 14:15
@github-actions github-actions bot added team/agent-devx-infra short review PR is simple enough to be reviewed quickly labels Nov 7, 2024
@FlorentClarret FlorentClarret added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Nov 7, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 48453715 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 273a9134-5470-46ba-be36-ec03cc3d6c27

Baseline: 71f9b0b
Comparison: 7722d2b
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +2.27 [-1.67, +6.21] 1 Logs
pycheck_lots_of_tags % cpu utilization +1.26 [-2.28, +4.81] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.69 [-0.03, +1.42] 1 Logs
idle_all_features memory utilization +0.58 [+0.48, +0.68] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.42 [+0.32, +0.52] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.33 [+0.28, +0.38] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.07 [-0.17, +0.31] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.27, +0.27] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.40, +0.38] 1 Logs
idle memory utilization -0.01 [-0.06, +0.03] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api ingress throughput -0.04 [-0.14, +0.07] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.18 [-0.37, +0.01] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.55 [-1.04, -0.06] 1 Logs
file_tree memory utilization -0.60 [-0.73, -0.47] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.82 [-0.87, -0.77] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_100ms_latency lost_bytes 6/10
file_to_blackhole_0ms_latency lost_bytes 8/10
idle_all_features memory_usage 9/10 bounds checks dashboard
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@AliDatadog
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 8, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-08 10:09:41 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 24m.

@dd-mergequeue dd-mergequeue bot merged commit e5da82e into main Nov 8, 2024
232 of 233 checks passed
@dd-mergequeue dd-mergequeue bot deleted the spencergilbert/update-jobowners branch November 8, 2024 10:30
@github-actions github-actions bot added this to the 7.61.0 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-devx-infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants