Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a config tree per configuration layers #30868

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

hush-hush
Copy link
Member

@hush-hush hush-hush commented Nov 7, 2024

What does this PR do?

Create a config tree per configuration layers. This PR also update the Set method in another commit to handle all layers.

@hush-hush hush-hush added changelog/no-changelog team/agent-shared-components qa/done QA done before merge and regressions are covered by tests labels Nov 7, 2024
@hush-hush hush-hush requested a review from dustmop November 7, 2024 15:37
@hush-hush hush-hush requested a review from a team as a code owner November 7, 2024 15:37
@hush-hush hush-hush requested review from louis-cqrl and removed request for louis-cqrl November 7, 2024 15:37
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Nov 7, 2024
Copy link

cit-pr-commenter bot commented Nov 7, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 98be8f58-ec85-41dd-9024-473c1ba20441

Baseline: f71aacb
Comparison: c203677
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.85 [+1.12, +2.58] 1 Logs
file_tree memory utilization +0.64 [+0.52, +0.77] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.09 [-0.11, +0.28] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.43, +0.46] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.02] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.29, +0.29] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.10, +0.07] 1 Logs
quality_gate_idle memory utilization -0.02 [-0.07, +0.03] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput -0.11 [-0.35, +0.13] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.15 [-0.64, +0.33] 1 Logs
quality_gate_idle_all_features memory utilization -0.32 [-0.42, -0.22] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.61 [-0.67, -0.55] 1 Logs
basic_py_check % cpu utilization -1.67 [-5.48, +2.14] 1 Logs
pycheck_lots_of_tags % cpu utilization -4.59 [-7.93, -1.25] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 6/10
file_to_blackhole_100ms_latency lost_bytes 8/10
quality_gate_idle memory_usage 8/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 9/10 bounds checks dashboard
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Nov 7, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 7, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=48546598 --os-family=ubuntu

Note: This applies to commit c203677

Copy link
Contributor

@dustmop dustmop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pkg/config/nodetreemodel/config.go Outdated Show resolved Hide resolved
pkg/config/nodetreemodel/config.go Outdated Show resolved Hide resolved
@hush-hush hush-hush force-pushed the maxime/create-config-layers branch from 76f65e5 to c203677 Compare November 8, 2024 10:52
@hush-hush
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 8, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-08 14:22:21 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 24m.

@dd-mergequeue dd-mergequeue bot merged commit 21b241e into main Nov 8, 2024
213 of 214 checks passed
@dd-mergequeue dd-mergequeue bot deleted the maxime/create-config-layers branch November 8, 2024 14:45
@github-actions github-actions bot added this to the 7.61.0 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants