Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit gowork, and update tasks to use it #31418

Merged
merged 15 commits into from
Dec 3, 2024
Merged

Conversation

KevinFairise2
Copy link
Member

@KevinFairise2 KevinFairise2 commented Nov 25, 2024

What does this PR do?

Add go.work file, and update our invoke tasks to work with it.
With that PR all the dependencies are automatically synced between all the modules of the workspace. With that we should no longer need to replace all the datadog-agent module to use the local version, this is what workspace does out of the box.

The inv tidy task has been updated and should now run go work sync which will automatically bump the dependencies across all the modules when a dependency is updated in a module.

All the replace instructions that point to datadog-agent in the modules will be removed in a follow up PR, we will also need to move the replace we have on external dependencies to go.work file instead of putting it in each individual module.

I had to disable go workspace for license linting job, otherwise it does not work well with the go mod vendor call (and does not work either with go work vendor). We should be able to remove the exception once we tackle: https://datadoghq.atlassian.net/jira/software/c/projects/ADXT/boards/6196/backlog?epics=visible&selectedIssue=ADXT-766&text=vendor

Motivation

Make dependency management easier

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 25, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=50223008 --os-family=ubuntu

Note: This applies to commit 81d480b

Copy link

cit-pr-commenter bot commented Nov 25, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: f96d91c1-7f67-4d5b-aca7-5be0c20393c5

Baseline: 0200b9d
Comparison: 81d480b
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +2.42 [-1.42, +6.25] 1 Logs
pycheck_lots_of_tags % cpu utilization +1.17 [-2.30, +4.65] 1 Logs
otel_to_otel_logs ingress throughput +1.11 [+0.35, +1.87] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.46 [-0.28, +1.20] 1 Logs
quality_gate_idle memory utilization +0.19 [+0.14, +0.23] 1 Logs bounds checks dashboard
file_to_blackhole_300ms_latency egress throughput +0.11 [-0.52, +0.74] 1 Logs
file_tree memory utilization +0.05 [-0.10, +0.20] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.71, +0.75] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.10, +0.10] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.82, +0.78] 1 Logs
quality_gate_idle_all_features memory utilization -0.05 [-0.16, +0.07] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput -0.06 [-0.83, +0.71] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.12 [-0.18, -0.06] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.15 [-0.61, +0.32] 1 Logs
quality_gate_logs % cpu utilization -0.18 [-3.10, +2.74] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.66 [-1.46, +0.14] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@KevinFairise2 KevinFairise2 added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Nov 27, 2024
@KevinFairise2 KevinFairise2 marked this pull request as ready for review November 27, 2024 09:53
@KevinFairise2 KevinFairise2 requested review from a team as code owners November 27, 2024 09:53
Copy link
Contributor

@BaptisteFoy BaptisteFoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for rc/fa owned files

Copy link
Member

@amenasria amenasria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 praise: ‏Left a comment, otherwise LGTM ! Nice work !

Comment on lines +130 to +131
ctx.run(f"go mod vendor{verbosity}", env={"GOWORK": "off"})
ctx.run(f"go mod tidy{verbosity}", env={"GOWORK": "off"})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 suggestion: ‏Could you please add a comment in the code to explain why setting the GOWORK to off here?

test/fakeintake
test/new-e2e
test/otel
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 praise
🎉

Copy link
Contributor

@julien-lebot julien-lebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🎉

@KevinFairise2 KevinFairise2 removed the request for review from liustanley December 2, 2024 10:20
@KevinFairise2 KevinFairise2 requested a review from a team as a code owner December 2, 2024 16:35
docs/dev/modules.md Outdated Show resolved Hide resolved
@KevinFairise2
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 3, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-03 08:19:42 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 23m.

@dd-mergequeue dd-mergequeue bot merged commit 5f0dfcf into main Dec 3, 2024
400 checks passed
@dd-mergequeue dd-mergequeue bot deleted the kfairise/gowork-clean branch December 3, 2024 08:50
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 3, 2024
@KevinFairise2 KevinFairise2 added qa/done QA done before merge and regressions are covered by tests and removed qa/no-code-change No code change in Agent code requiring validation labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.