Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings on sidecar to terminate on finished job #31543

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gabedos
Copy link
Contributor

@gabedos gabedos commented Nov 27, 2024

What does this PR do?

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added team/container-platform The Container Platform Team short review PR is simple enough to be reviewed quickly labels Nov 27, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 50079110 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=50079110 --os-family=ubuntu

Note: This applies to commit b39b1fc

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c9c8db3d-0b6d-43ba-af9e-f4312563cb54

Baseline: a768373
Comparison: b39b1fc
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle memory utilization +2.00 [+1.95, +2.06] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.46 [+0.41, +0.52] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.08 [-0.39, +0.54] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.07 [-0.71, +0.84] 1 Logs
otel_to_otel_logs ingress throughput +0.05 [-0.62, +0.73] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.05 [-0.75, +0.85] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.71, +0.74] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.10, +0.11] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.00 [-0.63, +0.63] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.12 [-0.90, +0.65] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.24 [-0.96, +0.49] 1 Logs
pycheck_lots_of_tags % cpu utilization -0.28 [-3.71, +3.16] 1 Logs
quality_gate_idle_all_features memory utilization -0.44 [-0.60, -0.28] 1 Logs bounds checks dashboard
file_tree memory utilization -2.24 [-2.36, -2.12] 1 Logs
basic_py_check % cpu utilization -3.22 [-7.01, +0.58] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 9/10
quality_gate_idle memory_usage 9/10 bounds checks dashboard
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
short review PR is simple enough to be reviewed quickly team/container-platform The Container Platform Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant