Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fleet) build the bootstrapper as a shell script on linux #31695

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

arbll
Copy link
Member

@arbll arbll commented Dec 3, 2024

This PR replaces the bootstrapper binary build by the embedded shell script.

The first script flavor we'll build is DJM/Data Job Monitorig so I'm hardcoding their name in this first pass to get the piping working.

This PR replaces the bootstrapper binary build by the embedded shell script.
@arbll arbll added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/fleet-automation labels Dec 3, 2024
@arbll arbll requested review from a team as code owners December 3, 2024 10:29
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 3, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 3, 2024

[Fast Unit Tests Report]

On pipeline 50293362 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

cit-pr-commenter bot commented Dec 3, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c14aed54-b8c4-4992-b519-ccd0a7303a0b

Baseline: 5f0dfcf
Comparison: 2772dff
Diff

Optimization Goals: ❌ Regression(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +5.77 [+1.88, +9.65] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +5.77 [+1.88, +9.65] 1 Logs
quality_gate_logs % cpu utilization +4.01 [+0.99, +7.04] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.25 [-0.53, +1.03] 1 Logs
file_tree memory utilization +0.23 [+0.08, +0.37] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.23 [-0.51, +0.96] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.15 [+0.09, +0.21] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.10 [-0.53, +0.72] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.03 [-0.71, +0.76] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.00 [-0.83, +0.84] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.12, +0.09] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.05 [-0.81, +0.72] 1 Logs
quality_gate_idle_all_features memory utilization -0.06 [-0.16, +0.04] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.14 [-0.61, +0.32] 1 Logs
quality_gate_idle memory utilization -0.26 [-0.31, -0.21] 1 Logs bounds checks dashboard
pycheck_lots_of_tags % cpu utilization -0.41 [-3.81, +3.00] 1 Logs
otel_to_otel_logs ingress throughput -0.63 [-1.33, +0.08] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_300ms_latency lost_bytes 9/10
file_to_blackhole_500ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

tasks/installer.py Outdated Show resolved Hide resolved
tasks/installer.py Outdated Show resolved Hide resolved
tasks/installer.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Dec 3, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 3, 2024

Gitlab CI Configuration Changes

Added Jobs

deploy_installer_install_scripts
deploy_installer_install_scripts:
  before_script:
  - ls $OMNIBUS_PACKAGE_DIR
  image: registry.ddbuild.io/ci/datadog-agent-buildimages/gitlab_agent_deploy$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
  needs:
  - installer-install-scripts
  rules:
  - if: $DEPLOY_INSTALLER == "true" || $DDR_WORKFLOW_ID != null
  script:
  - $S3_CP_CMD --recursive --exclude "*" --include "install-*.sh" "$OMNIBUS_PACKAGE_DIR"
    "${S3_RELEASE_INSTALLER_ARTIFACTS_URI}/scripts/"
  stage: deploy_packages
  tags:
  - arch:amd64
installer-install-scripts
installer-install-scripts:
  artifacts:
    expire_in: 2 weeks
    paths:
    - $OMNIBUS_PACKAGE_DIR
  image: registry.ddbuild.io/ci/datadog-agent-buildimages/deb_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
  needs:
  - go_mod_tidy_check
  - go_deps
  rules:
  - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
    when: never
  - when: on_success
  script:
  - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache.tar.xz -C $GOPATH/pkg/mod/cache
  - rm -f modcache.tar.xz
  - echo "About to build for $RELEASE_VERSION"
  - mkdir -p $OMNIBUS_PACKAGE_DIR
  - inv -e installer.build-linux-script && mv ./bin/installer/setup.sh $OMNIBUS_PACKAGE_DIR/install-djm.sh
  - ls -la $OMNIBUS_PACKAGE_DIR
  stage: package_build
  tags:
  - arch:amd64
  variables:
    KUBERNETES_CPU_REQUEST: 8
    KUBERNETES_MEMORY_LIMIT: 16Gi
    KUBERNETES_MEMORY_REQUEST: 16Gi
    RELEASE_VERSION: $RELEASE_VERSION_7

Removed Jobs

  • bootstrapper_build
  • deploy_installer_boostrapper

Changes Summary

Removed Modified Added Renamed
2 0 2 0

ℹ️ Diff available in the job log.

@arbll arbll requested a review from a team as a code owner December 3, 2024 19:57
@arbll
Copy link
Member Author

arbll commented Dec 4, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 4, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-04 13:50:53 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 23m.

@dd-mergequeue dd-mergequeue bot merged commit 20f20be into main Dec 4, 2024
437 of 438 checks passed
@dd-mergequeue dd-mergequeue bot deleted the arbll/bootstrapper-script branch December 4, 2024 14:32
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/fleet-automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants