Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the version to the slack notification for RC PRs #31710

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Dec 3, 2024

What does this PR do?

Add the version to the slack notification for RC PRs

Motivation

We sometimes have an overlap between two releases and it's a bit confusing because we have to open the link to know which version it is. I'm going to update the workflow once merged to include this

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@FlorentClarret FlorentClarret requested a review from a team as a code owner December 3, 2024 14:20
@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly team/agent-delivery labels Dec 3, 2024
@FlorentClarret FlorentClarret added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 3, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 50268616 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@FlorentClarret
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 3, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-03 14:50:09 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-12-03 15:08:33 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 23m.

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ff59648f-c10c-445d-b5e6-09886ad8435e

Baseline: 01c8ef8
Comparison: 0c6e860
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization +1.80 [-1.66, +5.26] 1 Logs
basic_py_check % cpu utilization +0.41 [-3.37, +4.20] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.39 [+0.33, +0.45] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.22 [-0.50, +0.94] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.11 [-0.66, +0.89] 1 Logs
file_tree memory utilization +0.07 [-0.08, +0.22] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.06 [-0.74, +0.86] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.05 [-0.70, +0.81] 1 Logs
otel_to_otel_logs ingress throughput +0.04 [-0.64, +0.73] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.04 [-0.80, +0.88] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.07, +0.11] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.03 [-0.66, +0.60] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.16 [-0.63, +0.30] 1 Logs
quality_gate_idle memory utilization -0.57 [-0.62, -0.52] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.98 [-1.09, -0.86] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -1.87 [-4.80, +1.06] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@dd-mergequeue dd-mergequeue bot merged commit 809bb8e into main Dec 3, 2024
225 of 228 checks passed
@dd-mergequeue dd-mergequeue bot deleted the florentclarret/slack-version branch December 3, 2024 15:32
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants