Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] sync yaml usage to v3 in pkg/security/secl #31718

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

paulcacheux
Copy link
Contributor

What does this PR do?

Policy tests currently use v3, and the actual code uses v2 which is strange. This PR syncs everyone on v3.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added component/system-probe team/agent-security short review PR is simple enough to be reviewed quickly labels Dec 3, 2024
@paulcacheux paulcacheux added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Dec 3, 2024
@paulcacheux paulcacheux marked this pull request as ready for review December 3, 2024 17:15
@paulcacheux paulcacheux requested a review from a team as a code owner December 3, 2024 17:15
@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=50282504 --os-family=ubuntu

Note: This applies to commit dabe490

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 3841e979-e9f3-459f-b1c1-583c60377268

Baseline: 2d20432
Comparison: dabe490
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +4.10 [+0.24, +7.96] 1 Logs
tcp_syslog_to_blackhole ingress throughput +1.35 [+1.29, +1.42] 1 Logs
quality_gate_idle memory utilization +0.27 [+0.22, +0.31] 1 Logs bounds checks dashboard
file_tree memory utilization +0.21 [+0.07, +0.35] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.13 [-0.51, +0.76] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.05 [-0.80, +0.90] 1 Logs
otel_to_otel_logs ingress throughput +0.03 [-0.64, +0.70] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.00 [-0.46, +0.46] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.03 [-0.13, +0.07] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.04 [-0.79, +0.71] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.08 [-0.85, +0.69] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.32 [-1.08, +0.44] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.38 [-1.11, +0.35] 1 Logs
pycheck_lots_of_tags % cpu utilization -0.68 [-4.08, +2.72] 1 Logs
quality_gate_logs % cpu utilization -1.91 [-4.86, +1.03] 1 Logs
quality_gate_idle_all_features memory utilization -2.00 [-2.10, -1.90] 1 Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_300ms_latency lost_bytes 7/10
file_to_blackhole_0ms_latency lost_bytes 9/10
file_to_blackhole_100ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@paulcacheux
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 4, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-04 08:34:49 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 22m.

@dd-mergequeue dd-mergequeue bot merged commit b2fc123 into main Dec 4, 2024
243 of 245 checks passed
@dd-mergequeue dd-mergequeue bot deleted the paulcacheux/yaml-v3-secl branch December 4, 2024 09:12
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants