Implement MergeFleetPolicy for nodetreemodel #31961
Merged
+57
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustmop
added
changelog/no-changelog
[deprecated] team/agent-shared-components
github-actions
bot
added
the
short review
github-actions
bot
added
medium review
Package size comparisonComparison with ancestor Diff per package
Decision |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=50702362 --os-family=ubuntuNote: This applies to commit 6e52c8f |
hush-hush
approved these changes
Dec 11, 2024
KevinFairise2
approved these changes
Dec 12, 2024
|
/merge |
Devflow running:
|
KSerrania
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implement the MergeFleetPolicy method. It reuses the readConfigurationFile method, but with its own source layer, and then merges the result into the config tree.
Motivation
Remove our dependency on viper.
Describe how you validated your changes
Functionality covered by a unit test, which matches the test for the previous viper method.
Possible Drawbacks / Trade-offs
Additional Notes