Move winproc to windows corechecks

[pgimalac]

What does this PR do?

Move the winproc check to the list of windows specific core checks.

Motivation

I had the following logs on Darwin:

DEBUG | (pkg/collector/scheduler.go:192 in getChecks) | Loading check instance for check 'winproc' using default loaders
DEBUG | (pkg/collector/python/loader.go:163 in Load) | Unable to load python module - datadog_checks.winproc: unable to import module 'datadog_checks.winproc': No module named 'datadog_checks.winproc'
DEBUG | (pkg/collector/python/loader.go:163 in Load) | Unable to load python module - winproc: unable to import module 'winproc': No module named 'winproc'
DEBUG | (pkg/collector/python/loader.go:171 in Load) | PyLoader returning unable to import module 'winproc': No module named 'winproc' for winproc
ERROR | (pkg/collector/scheduler.go:213 in getChecks) | Unable to load a check from instance of config 'winproc': Python Check Loader: unable to import module 'winproc': No module named 'winproc'; Core Check Loader: Check winproc not found in Catalog

Describe how you validated your changes

Checked that I didn't have those logs with the change.

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

[Fast Unit Tests Report]

On pipeline 51989660 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_deb-arm64-py3
• tests_deb-x64-py3
• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64
• tests_rpm-arm64-py3
• tests_rpm-x64-py3
• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor 7d64f0b33f6e8fa642f7c5317d1e25f2992d3091

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	1190.85MB	1190.85MB	140.00MB
datadog-agent-x86_64-rpm	0.00MB	✅	1200.17MB	1200.17MB	140.00MB
datadog-agent-x86_64-suse	0.00MB	✅	1200.17MB	1200.17MB	140.00MB
datadog-agent-arm64-deb	0.00MB	✅	935.11MB	935.11MB	140.00MB
datadog-agent-aarch64-rpm	0.00MB	✅	944.41MB	944.41MB	140.00MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	78.54MB	78.54MB	10.00MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	78.62MB	78.62MB	10.00MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	78.62MB	78.62MB	10.00MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	55.75MB	55.75MB	10.00MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	505.27MB	505.27MB	70.00MB
datadog-iot-agent-amd64-deb	0.00MB	✅	113.34MB	113.34MB	10.00MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	113.41MB	113.41MB	10.00MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	113.41MB	113.41MB	10.00MB
datadog-iot-agent-arm64-deb	0.00MB	✅	108.81MB	108.81MB	10.00MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	108.88MB	108.88MB	10.00MB

Decision

✅ Passed

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 80cb12d6-1fcf-4e13-a6b1-f339429bb9fc

Baseline: 7d64f0b
Comparison: 24c920e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+1.51	[+0.81, +2.21]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.22	[+0.14, +0.30]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	+0.14	[+0.01, +0.28]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.03	[-0.72, +0.78]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.01	[-0.90, +0.92]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.11, +0.13]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.02, +0.01]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.00	[-0.64, +0.63]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.05	[-0.95, +0.85]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.07	[-0.85, +0.70]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.07	[-0.92, +0.77]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.12	[-0.58, +0.34]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.16	[-0.95, +0.63]	1	Logs
➖	quality_gate_idle	memory utilization	-0.17	[-0.21, -0.14]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	-0.30	[-3.52, +2.92]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.73	[-0.80, -0.66]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[pgimalac]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2025-01-03 13:14:15 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 35m.

---

2025-01-03 13:53:06 UTC ℹ️ MergeQueue: This merge request was merged