do not build system-probe twice #32884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component/system-probe
short review
Gitlab CI Configuration ChangesModified Jobs.system-probe_build_common .system-probe_build_common:
artifacts:
expire_in: 2 weeks
paths:
- $CI_PROJECT_DIR/sysprobe-build-outputs.tar.xz
- $CI_PROJECT_DIR/sysprobe-build-outputs.tar.xz.sum
before_script:
- mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache.tar.xz -C $GOPATH/pkg/mod/cache
|| exit 101
- rm -f modcache.tar.xz
- find "$CI_BUILDS_DIR" ! -path '*DataDog/datadog-agent*' -depth
- find "$CI_BUILDS_DIR" ! -path '*DataDog/datadog-agent*' -delete || true
rules:
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- when: on_success
script:
- inv check-go-version
- - inv -e system-probe.build --strip-object-files
+ - inv -e system-probe.build-object-files --strip-object-files
? +++++++++++++
- - objdump -p $CI_PROJECT_DIR/$SYSTEM_PROBE_BINARIES_DIR/system-probe | egrep 'GLIBC_2\.(1[8-9]|[2-9][0-9])'
- && exit 1
- inv -e system-probe.save-build-outputs $CI_PROJECT_DIR/sysprobe-build-outputs.tar.xz
variables:
KUBERNETES_CPU_REQUEST: 6
KUBERNETES_MEMORY_LIMIT: 12Gi
KUBERNETES_MEMORY_REQUEST: 6Gibuild_system-probe-arm64 build_system-probe-arm64:
artifacts:
expire_in: 2 weeks
paths:
- $CI_PROJECT_DIR/sysprobe-build-outputs.tar.xz
- $CI_PROJECT_DIR/sysprobe-build-outputs.tar.xz.sum
before_script:
- mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache.tar.xz -C $GOPATH/pkg/mod/cache
|| exit 101
- rm -f modcache.tar.xz
- find "$CI_BUILDS_DIR" ! -path '*DataDog/datadog-agent*' -depth
- find "$CI_BUILDS_DIR" ! -path '*DataDog/datadog-agent*' -delete || true
image: registry.ddbuild.io/ci/datadog-agent-buildimages/system-probe_arm64$DATADOG_AGENT_SYSPROBE_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_SYSPROBE_BUILDIMAGES
needs:
- go_deps
rules:
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- when: on_success
script:
- inv check-go-version
- - inv -e system-probe.build --strip-object-files
+ - inv -e system-probe.build-object-files --strip-object-files
? +++++++++++++
- - objdump -p $CI_PROJECT_DIR/$SYSTEM_PROBE_BINARIES_DIR/system-probe | egrep 'GLIBC_2\.(1[8-9]|[2-9][0-9])'
- && exit 1
- inv -e system-probe.save-build-outputs $CI_PROJECT_DIR/sysprobe-build-outputs.tar.xz
stage: binary_build
tags:
- arch:arm64
variables:
ARCH: arm64
KUBERNETES_CPU_REQUEST: 6
KUBERNETES_MEMORY_LIMIT: 12Gi
KUBERNETES_MEMORY_REQUEST: 6Gibuild_system-probe-x64 build_system-probe-x64:
artifacts:
expire_in: 2 weeks
paths:
- $CI_PROJECT_DIR/sysprobe-build-outputs.tar.xz
- $CI_PROJECT_DIR/sysprobe-build-outputs.tar.xz.sum
before_script:
- mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache.tar.xz -C $GOPATH/pkg/mod/cache
|| exit 101
- rm -f modcache.tar.xz
- find "$CI_BUILDS_DIR" ! -path '*DataDog/datadog-agent*' -depth
- find "$CI_BUILDS_DIR" ! -path '*DataDog/datadog-agent*' -delete || true
image: registry.ddbuild.io/ci/datadog-agent-buildimages/system-probe_x64$DATADOG_AGENT_SYSPROBE_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_SYSPROBE_BUILDIMAGES
needs:
- go_deps
rules:
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- when: on_success
script:
- inv check-go-version
- - inv -e system-probe.build --strip-object-files
+ - inv -e system-probe.build-object-files --strip-object-files
? +++++++++++++
- - objdump -p $CI_PROJECT_DIR/$SYSTEM_PROBE_BINARIES_DIR/system-probe | egrep 'GLIBC_2\.(1[8-9]|[2-9][0-9])'
- && exit 1
- inv -e system-probe.save-build-outputs $CI_PROJECT_DIR/sysprobe-build-outputs.tar.xz
stage: binary_build
tags:
- arch:amd64
variables:
ARCH: amd64
KUBERNETES_CPU_REQUEST: 6
KUBERNETES_MEMORY_LIMIT: 12Gi
KUBERNETES_MEMORY_REQUEST: 6GiChanges Summary
ℹ️ Diff available in the job log. |
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
|
[Fast Unit Tests Report] On pipeline 52766059 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 15f12d5 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +2.23 | [-0.97, +5.44] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.60 | [+0.54, +0.67] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.08 | [-0.72, +0.88] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.03 | [-0.05, +0.12] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.02 | [-0.83, +0.87] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.10, +0.12] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.01 | [-0.66, +0.68] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.02, +0.01] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.02 | [-0.15, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.02 | [-0.93, +0.89] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | -0.02 | [-0.66, +0.61] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.09 | [-0.56, +0.38] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | -0.09 | [-0.94, +0.75] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.21 | [-1.04, +0.62] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.66 | [-0.70, -0.62] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.19 | [-1.90, -0.49] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
paulcacheux
changed the title
paulcacheux
changed the title
paulcacheux
added
changelog/no-changelog
qa/done
chouquette
approved these changes
Jan 13, 2025
gjulianm
approved these changes
Jan 13, 2025
|
/merge |
Devflow running:
|
brycekahle
reviewed
Jan 14, 2025
| @@ -12,9 +12,7 @@ | |||
| - find "$CI_BUILDS_DIR" ! -path '*DataDog/datadog-agent*' -delete || true # Allow failure, we can't remove parent folders of datadog-agent | |||
| script: | |||
| - inv check-go-version | |||
| - inv -e system-probe.build --strip-object-files | |||
| # fail if references to glibc >= 2.18 | |||
| - objdump -p $CI_PROJECT_DIR/$SYSTEM_PROBE_BINARIES_DIR/system-probe | egrep 'GLIBC_2\.(1[8-9]|[2-9][0-9])' && exit 1 | |||
There was a problem hiding this comment.
What happened to this? We need this safeguard to ensure we don't accidentally start using a newer glibc.
There was a problem hiding this comment.
Basically this has never worked, since we have a safeguard on the wrong binary. Happy to spawn another PR to add this safeguard on the actually binary shipped, the one built by omnibus
There was a problem hiding this comment.
The omnibus building of the system-probe binary is a somewhat recent addition. They could mismatch, from a glibc standpoint, if the buildimages differed.
There was a problem hiding this comment.
I will spawn a PR to add this check you are right, better be safe on this front
github-actions
bot
added
medium review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR:
object-files/build-object-files, by keeping only one and creating an alias for the other nameMotivation
Describe how you validated your changes
Validated that the system probe build in the
build_system-probejob was not used (not even exported). And all the new e2e tests are green.Possible Drawbacks / Trade-offs
Additional Notes