Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go.opentelemetry.io/collector/otelcol #32952

Closed
wants to merge 2 commits into from
Closed

Conversation

keisku
Copy link
Contributor

@keisku keisku commented Jan 14, 2025

What does this PR do?

Update go.opentelemetry.io/collector/otelcol.

Motivation

#32947

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added team/agent-devx-loops long review PR is complex, plan time to review it labels Jan 14, 2025
Copy link

Go Package Import Differences

Baseline: 09be5c8
Comparison: c788e17

binaryosarchchange
agentlinuxamd64
+3, -3
+container/ring
-go.opentelemetry.io/collector/config/internal
-go.opentelemetry.io/collector/extension/experimental/storage
+go.opentelemetry.io/collector/extension/xextension/storage
-go.opentelemetry.io/collector/receiver/internal
+go.opentelemetry.io/collector/receiver/receiverhelper/internal
agentlinuxarm64
+3, -3
+container/ring
-go.opentelemetry.io/collector/config/internal
-go.opentelemetry.io/collector/extension/experimental/storage
+go.opentelemetry.io/collector/extension/xextension/storage
-go.opentelemetry.io/collector/receiver/internal
+go.opentelemetry.io/collector/receiver/receiverhelper/internal
agentwindowsamd64
+3, -3
+container/ring
-go.opentelemetry.io/collector/config/internal
-go.opentelemetry.io/collector/extension/experimental/storage
+go.opentelemetry.io/collector/extension/xextension/storage
-go.opentelemetry.io/collector/receiver/internal
+go.opentelemetry.io/collector/receiver/receiverhelper/internal
agentdarwinamd64
+3, -3
+container/ring
-go.opentelemetry.io/collector/config/internal
-go.opentelemetry.io/collector/extension/experimental/storage
+go.opentelemetry.io/collector/extension/xextension/storage
-go.opentelemetry.io/collector/receiver/internal
+go.opentelemetry.io/collector/receiver/receiverhelper/internal
agentdarwinarm64
+3, -3
+container/ring
-go.opentelemetry.io/collector/config/internal
-go.opentelemetry.io/collector/extension/experimental/storage
+go.opentelemetry.io/collector/extension/xextension/storage
-go.opentelemetry.io/collector/receiver/internal
+go.opentelemetry.io/collector/receiver/receiverhelper/internal
iot-agentlinuxamd64
+3, -3
+container/ring
-go.opentelemetry.io/collector/config/internal
-go.opentelemetry.io/collector/extension/experimental/storage
+go.opentelemetry.io/collector/extension/xextension/storage
-go.opentelemetry.io/collector/receiver/internal
+go.opentelemetry.io/collector/receiver/receiverhelper/internal
iot-agentlinuxarm64
+3, -3
+container/ring
-go.opentelemetry.io/collector/config/internal
-go.opentelemetry.io/collector/extension/experimental/storage
+go.opentelemetry.io/collector/extension/xextension/storage
-go.opentelemetry.io/collector/receiver/internal
+go.opentelemetry.io/collector/receiver/receiverhelper/internal
heroku-agentlinuxamd64
+3, -3
+container/ring
-go.opentelemetry.io/collector/config/internal
-go.opentelemetry.io/collector/extension/experimental/storage
+go.opentelemetry.io/collector/extension/xextension/storage
-go.opentelemetry.io/collector/receiver/internal
+go.opentelemetry.io/collector/receiver/receiverhelper/internal
serverlesslinuxamd64
+3, -3
+container/ring
-go.opentelemetry.io/collector/config/internal
-go.opentelemetry.io/collector/extension/experimental/storage
+go.opentelemetry.io/collector/extension/xextension/storage
-go.opentelemetry.io/collector/receiver/internal
+go.opentelemetry.io/collector/receiver/receiverhelper/internal
serverlesslinuxarm64
+3, -3
+container/ring
-go.opentelemetry.io/collector/config/internal
-go.opentelemetry.io/collector/extension/experimental/storage
+go.opentelemetry.io/collector/extension/xextension/storage
-go.opentelemetry.io/collector/receiver/internal
+go.opentelemetry.io/collector/receiver/receiverhelper/internal

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=52922880 --os-family=ubuntu

Note: This applies to commit c788e17

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 09be5c89b20db800c5fe99671da16c61eca8e724

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.11MB ⚠️ 1004.92MB 1004.81MB 0.50MB
datadog-agent-arm64-deb 0.11MB ⚠️ 988.88MB 988.77MB 0.50MB
datadog-agent-x86_64-rpm 0.11MB ⚠️ 1014.59MB 1014.48MB 0.50MB
datadog-agent-x86_64-suse 0.11MB ⚠️ 1014.59MB 1014.48MB 0.50MB
datadog-agent-aarch64-rpm 0.11MB ⚠️ 998.53MB 998.42MB 0.50MB
datadog-dogstatsd-arm64-deb 0.01MB ⚠️ 56.34MB 56.33MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 58.91MB 58.90MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 58.91MB 58.90MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 58.83MB 58.83MB 0.50MB
datadog-iot-agent-aarch64-rpm -0.00MB 89.98MB 89.98MB 0.50MB
datadog-iot-agent-arm64-deb -0.00MB 89.91MB 89.91MB 0.50MB
datadog-iot-agent-x86_64-rpm -0.01MB 93.92MB 93.93MB 0.50MB
datadog-iot-agent-x86_64-suse -0.01MB 93.92MB 93.92MB 0.50MB
datadog-iot-agent-amd64-deb -0.01MB 93.85MB 93.86MB 0.50MB
datadog-heroku-agent-amd64-deb -0.01MB 532.55MB 532.56MB 0.50MB

Decision

⚠️ Warning

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 353ea80e-1cea-4477-8807-2350e11db79f

Baseline: 09be5c8
Comparison: c788e17
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +2.12 [+1.40, +2.83] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.63 [-0.16, +1.43] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.61 [+0.53, +0.68] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.38 [-0.40, +1.17] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.06 [-0.83, +0.95] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.06 [-0.60, +0.72] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.04 [-0.60, +0.67] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.03 [-0.89, +0.96] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.09, +0.11] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.89, +0.87] 1 Logs
file_tree memory utilization -0.02 [-0.18, +0.13] 1 Logs
quality_gate_idle memory utilization -0.04 [-0.07, -0.00] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.11 [-0.19, -0.03] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.22 [-0.69, +0.24] 1 Logs
quality_gate_logs % cpu utilization -1.65 [-4.76, +1.46] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@songy23
Copy link
Member

songy23 commented Jan 14, 2025

Here's a PR that does the same #32863

cc @jackgopack4

@jackgopack4
Copy link
Contributor

rebasing that PR and seeing if tests pass

@keisku
Copy link
Contributor Author

keisku commented Jan 14, 2025

#32863 is going to do the same thing.

@keisku keisku closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
long review PR is complex, plan time to review it team/agent-devx-loops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants