-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CWS] sysctl_snapshot event #34599
base: will/sysctl-event
Are you sure you want to change the base?
[CWS] sysctl_snapshot event #34599
Conversation
c8b822e
to
d1415b8
Compare
7306616
to
baf55a5
Compare
d1415b8
to
9697e68
Compare
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: a0caaff Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | quality_gate_logs | % cpu utilization | +1.07 | [-1.85, +4.00] | 1 | Logs |
➖ | file_tree | memory utilization | +0.36 | [+0.31, +0.42] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | +0.14 | [+0.08, +0.20] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.14 | [-0.33, +0.61] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | +0.05 | [-0.63, +0.73] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.02 | [-0.78, +0.82] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | +0.01 | [-0.83, +0.85] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.27, +0.28] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.02, +0.02] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | -0.01 | [-0.84, +0.83] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.01 | [-0.90, +0.88] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.01 | [-0.63, +0.61] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -0.02 | [-0.07, +0.03] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_500ms_latency | egress throughput | -0.10 | [-0.89, +0.69] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.16 | [-0.93, +0.62] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.19 | [-0.24, -0.13] | 1 | Logs |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | intake_connections | 10/10 | |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
73c4cd6
to
f61b324
Compare
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=57466650 --os-family=ubuntu Note: This applies to commit ef84786 |
Static quality checks ✅Please find below the results from static quality gates Successful checksInfo
|
baf55a5
to
95d38d8
Compare
f61b324
to
ef84786
Compare
What does this PR do?
This PR introduces the
sysctl_snapshot
event which snapshots periodically the system control parameters in/proc/sys
(and the few security relevant ones in/sys/kernel/security
) and send the output to Datadog.2 new parameters were added in order to control this periodical snapshot:
runtime_security_config.sysctl_snapshot.enabled
: controls if the system control parameter periodical snapshot should be activated:runtime_security_config.sysctl_snapshot.period
: controls the period at which thesysctl_snapshot
events should be sent.Motivation
This PR introduces the
sysctl_snapshot
event which completes the requirements for tracking sysctl parameters (along with thesysctl
event type introduced in #34482).Describe how you validated your changes
Enable the feature with the configuration parameter, reduce the period and start the agent.
Wait for the configured duration.
You should see a
sysctl_snapshot
event sent to Datadog.