-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix upgrade.yml workflow failure #353
Conversation
working-directory: ./ | ||
- name: Upload patch | ||
if: steps.create_patch.outputs.patch_created | ||
uses: actions/upload-artifact@v4 | ||
uses: actions/upload-artifact@v4.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
When using a third party action, one needs to provide its GitHub path (owner/project
) and can eventually pin it to a Git ref (a branch name, a Git tag, or a commit hash).
No pinned Git ref means the action uses the latest commit of the default branch each time it runs, eventually running newer versions of the code that were not audited by Datadog. Specifying a Git tag is better, but since they are not immutable, using a full length hash is recommended to make sure the action content is actually frozen to some reviewed state.
Be careful however, as even pinning an action by hash can be circumvented by attackers still. For instance, if an action relies on a Docker image which is itself not pinned to a digest, it becomes possible to alter its behaviour through the Docker image without actually changing its hash. You can learn more about this kind of attacks in Unpinnable Actions: How Malicious Code Can Sneak into Your GitHub Actions Workflows. Pinning actions by hash is still a good first line of defense against supply chain attacks.
Additionally, pinning by hash or tag means the action won’t benefit from newer version updates if any, including eventual security patches. Make sure to regularly check if newer versions for an action you use are available. For actions coming from a very trustworthy source, it can make sense to use a laxer pinning policy to benefit from updates as soon as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is generated code.
bf61c0a
to
5b3bd0b
Compare
8b1eddb
to
2d909f6
Compare
7e8ee6a
to
1b80ba6
Compare
6bcd98c
to
9ae3d9e
Compare
9ae3d9e
to
8aec7a7
Compare
Motivation
The
upgrade.yml
workflow upgrades the version of dependencies. It has been failing for a long time (sample GitHub Action run)because it requires min Node.js version of 16.0.0 but our Datadog CDK Construct requires
14.15.0
, and as a result, theprojen
framework uses version14.15.0
to runupgrade.yml
. I didn't find a way to makeupgrade.yml
run a later Node.js version without updating theminNodeVersion
field of our CDK Construct.What does this PR do?
Fixes
upgrade.yml
workflow. Details:package.json
, changeprojen
version from^0.81.8
to^0.91.6
(latest so far).projenrc.js
, changeminNodeVersion
from14.15.0
to18.18.0
, which is required bystylistic/eslint-plugin
package (see GitHub Action log)npx projen
Testing Guidelines
Automated tests
Pass the existing unit tests and integration tests
Manual tests
Steps:
upgrade.yml
workflow on this branchResult:
Additional Notes
This is a breaking change in that it changes the required minimum node version
minNodeVersion
from14.15.0
to18.18.0
. Therefore I will first merge this PR into the branchyiming.luo/v2-2
, which will include the commits to be published in a major version bump (fromv2-1.22.0
tov2-2.0.0
). I will push more breaking changes to this branch, then bump the major version.Types of Changes
Check all that apply