Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Warning on Installation of packages([email protected], [email protected], [email protected]) #1378

Open
oleksiyPetlyuk opened this issue Jul 18, 2024 · 13 comments

Comments

@oleksiyPetlyuk
Copy link

Bug description

On installing I got the following warnings:

npm WARN deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm WARN deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported

Describe what you expected

I expect no warnings to be thrown.

Steps to reproduce the issue

npm install -g @datadog/datadog-ci

Additional context

OS Version: macOS 14.5
Node Version: v16.18.1
Package Manager: NPM 8.19.2

Command

flutter-symbols

@oleksiyPetlyuk oleksiyPetlyuk added the bug Something isn't working label Jul 18, 2024
This was referenced Jul 19, 2024
@Drarig29
Copy link
Contributor

Hi @oleksiyPetlyuk! Thanks for reporting. We are on it 🙇

@Drarig29
Copy link
Contributor

Drarig29 commented Jul 31, 2024

Released in v2.40.2

@Drarig29 Drarig29 reopened this Jul 31, 2024
@Drarig29
Copy link
Contributor

Just checked, and we now have a new warning...

npm warn deprecated [email protected]: Package is no longer maintained

@Drarig29
Copy link
Contributor

Will be fixed in the next release

@arthurbarbero
Copy link

New error on installing dependencies with glob:11

error [email protected]: The engine "node" is incompatible with this module. Expected version "20 || >=22". Got "18.20.4"

Will Node 18 still be supported on this new release?

@Drarig29
Copy link
Contributor

Drarig29 commented Aug 1, 2024

Hi! Here is another example of warnings from NPM:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '20 || >=22' },
npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
npm WARN EBADENGINE }

I'll revert the related PR because the original warning was totally OK to have:

npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported

Note that we cannot use glob v9 either, as it only supports Node.js >= 16, while we still currently support Node.js >= 14.

@Drarig29
Copy link
Contributor

Drarig29 commented Aug 1, 2024

@arthurbarbero @pkat fixed in v2.40.3, sorry for the inconvenience.

@Drarig29
Copy link
Contributor

Drarig29 commented Aug 1, 2024

@oleksiyPetlyuk reverting the PR brought back the following warnings:

npm WARN deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported

The inflight package is a dependency of glob@7 and glob@8, and we can't upgrade to glob@>=9 without losing support for Node.js 12, 14 and 16.

I'll close this issue, as they are only warnings.

@Drarig29 Drarig29 closed this as completed Aug 1, 2024
@arthurbarbero
Copy link

@Drarig29 I tried to install and still got errors, now on [email protected]:

error [email protected]: The engine "node" is incompatible with this module. Expected version "20 || >=22". Got "18.19.0"

Could you please take a look again? Thank you so much!

@Drarig29
Copy link
Contributor

Drarig29 commented Aug 1, 2024

@arthurbarbero it should finally be fixed in v2.41.0

@arthurbarbero
Copy link

@Drarig29 Now its working, thanks!

@Drarig29 Drarig29 added wontfix This will not be worked on and removed bug Something isn't working labels Oct 15, 2024
@emanueljacob
Copy link

emanueljacob commented Jan 7, 2025

The inflight package is a dependency of glob@7 and glob@8, and we can't upgrade to glob@>=9 without losing support for Node.js 12, 14 and 16.

I'll close this issue, as they are only warnings.

@Drarig29
how long do you plan to support node.js <= 16? those versions are not even under active maintenance anymore and security support has ended in Sep 2023... 🤔 isn't it time to leave that behind?

could you reopen this and add support for glob in versions >=9 please?

@Drarig29
Copy link
Contributor

Hi @emanueljacob! We are in the process of making a major release of datadog-ci to drop support of node.js < 18.

I'll reopen this issue, and the following PRs should finally close it:

@Drarig29 Drarig29 reopened this Feb 24, 2025
@Drarig29 Drarig29 removed the wontfix This will not be worked on label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants