[dep] Drop rimraf in production code #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 7086 Passed, 0 Skipped, 3m 7.71s Total Time |
AntoineDona
approved these changes
Feb 24, 2025
BenoitZugmeyer
approved these changes
Feb 24, 2025
Drarig29
changed the title
5.0.10
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Note
This PR is based on #1382, which had to be reverted (#1401) because it was bumping
rimrafto its latest version (6.0.1), which has dropped support for Node 18: https://github.com/isaacs/rimraf#v5-to-v6Related to #1378
This PR removes
rimraffrom production code (it's still used indevDependencies).How?
Replace
rimrafwithrmfromfs/promisesReview checklist