Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable products using flags #621

Merged
merged 14 commits into from
Jan 31, 2025
Merged

enable products using flags #621

merged 14 commits into from
Jan 31, 2025

Conversation

juli1
Copy link
Collaborator

@juli1 juli1 commented Jan 30, 2025

What problem are you trying to solve?

We want to be able to enable/disable each feature (static analysis, secret)

What is your solution?

image

Add a flag for each product. Specifically, enable-static-analysis or enable-secrets, which can. be true or false.

What the reviewer should know

We had previously a --secrets option. We will be deprecating it in further releases.

Testing

@juli1 juli1 requested a review from jasonforal January 30, 2025 16:11
@juli1 juli1 requested a review from a team as a code owner January 30, 2025 16:11
Copy link
Collaborator

@jasonforal jasonforal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See code annotations, but additionally, we probably shouldn't be making network calls to fetch all static analysis rulesets if it's not enabled

crates/bins/src/bin/datadog-static-analyzer-git-hook.rs Outdated Show resolved Hide resolved
.github/workflows/check-regressions.yml Outdated Show resolved Hide resolved
@jasonforal jasonforal self-requested a review January 31, 2025 21:40
@juli1 juli1 merged commit e3d32d1 into main Jan 31, 2025
75 checks passed
@juli1 juli1 deleted the julien/flags-enable-sa-secrets branch January 31, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants