Skip to content

Commit

Permalink
mention zero subscribers bug
Browse files Browse the repository at this point in the history
  • Loading branch information
tlhunter committed May 16, 2024
1 parent 9d87db0 commit 040017b
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions checks.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,11 @@ function hasFullSupport() {
}
module.exports.hasFullSupport = hasFullSupport;

// Node.js v19.9.0 has the "zero subscribers bug" which is pretty nasty.
// for that reason we overwrite the TracingChannel implementation entirely.
function hasTracingChannel() {
return (MAJOR >= 20)
// || (MAJOR === 19 && MINOR >= 9)
|| (MAJOR === 18 && MINOR >= 19);
}
module.exports.hasTracingChannel = hasTracingChannel;
Expand All @@ -33,11 +36,6 @@ function hasGarbageCollectionBug() {
}
module.exports.hasGarbageCollectionBug = hasGarbageCollectionBug;

function hasZeroSubscribersBug() {
return MAJOR === 19 && MINOR === 9;
}
module.exports.hasZeroSubscribersBug = hasZeroSubscribersBug;

function hasChannelStoreMethods() {
return MAJOR >= 20
|| (MAJOR === 19 && MINOR >= 9);
Expand Down

0 comments on commit 040017b

Please sign in to comment.