Add propagation string case functions and Array.join function #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iunanua
reviewed
Mar 8, 2024
uurien
reviewed
Mar 12, 2024
uurien
reviewed
Mar 12, 2024
src/api/array_join.cc
Outdated
| int separatorLength) { | ||
| auto length = arr->Length(); | ||
| int offset = 0; | ||
| auto newRanges = transaction->GetSharedVectorRange(); |
There was a problem hiding this comment.
We are getting and potentially creating a new SharedVector each time that join method is executed, even if it doesn't have any tainted object. Can we delay the initialization of newRanges to the point that we know that it will be necessary?
src/api/string_case.cc
Outdated
| } | ||
|
|
||
| try { | ||
| auto ranges = taintedObj ? taintedObj->getRanges() : nullptr; |
There was a problem hiding this comment.
The : nullptr is not possible, you're already checking !taintedObj in L57.
Suggested change
| auto ranges = taintedObj ? taintedObj->getRanges() : nullptr; | |
| auto ranges = taintedObj->getRanges(); |
CarlesDD
force-pushed
the
ccapell/extend-taint-tracking-operations
branch
from
1cbd392 to
051df64
Compare
CarlesDD
force-pushed
the
ccapell/extend-taint-tracking-operations
branch
from
6c968b4 to
c6f7d0c
Compare
CarlesDD
force-pushed
the
ccapell/extend-taint-tracking-operations
branch
from
c6f7d0c to
155bbe0
Compare
uurien
reviewed
Mar 22, 2024
uurien
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds propagation for string case functions
toLowerCaseandtoUpperCase.Adds propagation for Array.join function.
Motivation
Improve propagation.
Checklist
APPSEC-47443