RUM-7797 Anonymous RUM Identifier #2487
Conversation
| anonymousIdKey, | ||
| null, | ||
| AnonymousIdentifierReadCallback { anonymousId -> | ||
| if (anonymousId == null) { |
There was a problem hiding this comment.
Are you sure wee need this lambda here? 🤔 It basically just add more instructions than saves
Just to consider:
You have an object, implementing DataStoreReadCallback :
object : DataStoreReadCallback<UUID>{
override fun onSuccess(dataStoreContent: DataStoreContent<UUID>?) {
core.setAnonymousId(dataStoreContent?.data)
}
override fun onFailure() {
val newAnonymousId = UUID.randomUUID()
dataStore.setValue(
anonymousIdKey,
newAnonymousId,
0,
null,
AnonymousIdentifierSerializer()
)
core.setAnonymousId(newAnonymousId)
}
}
And that's it, no AnonymousIdentifierReadCallback class, no if(anonymousId == null) and rest logic...
| @@ -73,6 +73,14 @@ object Rum { | |||
|
|
|||
| sdkCore.registerFeature(rumFeature) | |||
|
|
|||
| sdkCore.getFeature(rumFeature.name)?.dataStore?.let { | |||
| val anonymousIdentifierManager = AnonymousIdentifierManager( | |||
There was a problem hiding this comment.
Note
Not sure that we need to create an instance of stateless class just to call one method... Maybe some static function will be better here?
|
Running from the root of the project will help you to overcome detekt problems. |
| import com.datadog.android.core.persistence.datastore.DataStoreContent | ||
| import java.util.UUID | ||
|
|
||
| internal interface AnonymousIdentifierManaging { |
There was a problem hiding this comment.
Perhaps renaming to
| internal interface AnonymousIdentifierManaging { | |
| internal interface AnonymousIdentifierManagement { |
| * @property id a unique identifier for the user, or null | ||
| * @property name the name of the user, or null | ||
| * @property email the email address of the user, or null | ||
| * @property additionalProperties a dictionary of custom properties attached to the current user | ||
| */ | ||
| data class UserInfo( | ||
| val anonymousId: String? = null, |
There was a problem hiding this comment.
In terms of naming, should we make it more explicit that this is an identifier of the device between sessions? anonymousDeviceId?
| }, | ||
| "anonymous_id": { | ||
| "type": "string", | ||
| "description": "Identifier of the user across sessions", |
There was a problem hiding this comment.
In some places it says identifier of the user and in others identifier of the device so I think we need to have a unified definition
| @@ -0,0 +1,30 @@ | |||
| { | |||
| "$schema": "http://json-schema.org/draft-07/schema", | |||
There was a problem hiding this comment.
Several changes that don't look directly connected to the pr are here due to updating the schemas. Perhaps we could update the schemas in a separate pr
What and why?
Adds capability of tracking anonymous id (enabled by default). This data allows linking sessions coming from the same device.
How?
Following proposal from this RFC (internal) it reuses data store mechanism, and based on configuration it generates and reuses stored identifier.
This identifier is attached to
UserInfoobject (schema already updated), which is enriching other SDK events.Motivation
This extra property adds ability to link sessions coming from the same device.
Additional Notes
The identifier is read asynchronously from a file, which means RUM events created immediately after calling
RUM.enable()will not include it. However, this is not an issue since theanonymous_idbelongs to the Session entity. As long as theanonymous_idis present in at least in one event, it is sufficient for linking.Review checklist (to be filled by reviewers)