Skip to content

Conversation

typotter
Copy link

@typotter typotter commented Oct 9, 2025

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@typotter typotter changed the base branch from develop to feature/feature-flagging October 9, 2025 08:03
@typotter typotter changed the base branch from feature/feature-flagging to typo/FFL-1112-flagging-proxy-custom-precomputed-assignments-endpoint October 9, 2025 08:03
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 83.24324% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.77%. Comparing base (740290d) to head (be2f0e8).
⚠️ Report is 34 commits behind head on feature/feature-flagging.

Files with missing lines Patch % Lines
.../flags/featureflags/internal/DatadogFlagsClient.kt 84.17% 9 Missing and 10 partials ⚠️
...ags/internal/persistence/FlagsStateDeserializer.kt 77.14% 8 Missing ⚠️
...oid/flags/featureflags/internal/NoOpFlagsClient.kt 0.00% 4 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           feature/feature-flagging    #2923      +/-   ##
============================================================
+ Coverage                     70.69%   70.77%   +0.08%     
============================================================
  Files                           834      836       +2     
  Lines                         30378    30491     +113     
  Branches                       5131     5162      +31     
============================================================
+ Hits                          21474    21579     +105     
- Misses                         7444     7447       +3     
- Partials                       1460     1465       +5     
Files with missing lines Coverage Δ
.../datadog/android/flags/featureflags/FlagsClient.kt 37.36% <ø> (ø)
...reflags/internal/model/PrecomputedFlagConstants.kt 100.00% <100.00%> (ø)
.../android/flags/internal/ExposureEventsProcessor.kt 100.00% <100.00%> (ø)
...adog/android/flags/internal/model/ExposureEvent.kt 100.00% <100.00%> (ø)
...roid/flags/internal/net/ExposuresRequestFactory.kt 100.00% <100.00%> (ø)
...lags/internal/storage/ExposureEventRecordWriter.kt 100.00% <100.00%> (ø)
...otlin/com/datadog/android/flags/model/ErrorCode.kt 100.00% <100.00%> (ø)
...m/datadog/android/flags/model/ResolutionDetails.kt 100.00% <100.00%> (ø)
...oid/flags/featureflags/internal/NoOpFlagsClient.kt 69.57% <0.00%> (-14.65%) ⬇️
...ags/internal/persistence/FlagsStateDeserializer.kt 84.21% <77.14%> (-0.27%) ⬇️
... and 1 more

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@typotter typotter force-pushed the typo/FFL-1112-flagging-proxy-custom-precomputed-assignments-endpoint branch from 2b5bcf6 to 211e111 Compare October 14, 2025 20:37
@typotter typotter force-pushed the typo/FFL-1184-resolve-value-method branch from 77e34af to 287fa8a Compare October 15, 2025 07:05
Base automatically changed from typo/FFL-1112-flagging-proxy-custom-precomputed-assignments-endpoint to feature/feature-flagging October 16, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants