Handle OTEL reserved attributes when using AttributeKeys (Fixes #2935) #2940
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR extracts the code to handle OTEL reserved attributes when setting a new key with
setAttribute(@NonNull String key, @Nullable String value)
and applies it also to thesetAttribute(AttributeKey<T> key, @Nullable T value)
method.Test coverage has also been added to
OtelSpanBuilder
.Motivation
Setting OTEL reserved attributes with:
or
had no result using the latest
dd-sdk-android
release.See #2935 for more info.
Review checklist (to be filled by reviewers)