feat: Support sending anonymous user ids in logs. #2945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzybinary
force-pushed
the
jward/anonymous-id-on-logs
branch
from
3cf7ee6 to
2a0b44a
Compare
|
🎯 Code Coverage 🔗 Commit SHA: 514fcec | Docs | Was this helpful? Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2945 +/- ##
===========================================
- Coverage 71.02% 70.81% -0.22%
===========================================
Files 829 829
Lines 30381 30382 +1
Branches 5183 5183
===========================================
- Hits 21578 21513 -65
- Misses 7347 7403 +56
- Partials 1456 1466 +10
🚀 New features to boost your workflow:
|
fuzzybinary
force-pushed
the
jward/anonymous-id-on-logs
branch
from
2a0b44a to
32fb2b1
Compare
0xnm
previously approved these changes
Oct 16, 2025
| import fr.xgouchet.elmyr.junit5.ForgeExtension | ||
| import org.assertj.core.api.Assertions.assertThat | ||
| import org.junit.jupiter.api.BeforeEach | ||
| import org.junit.jupiter.api.RepeatedTest |
| } | ||
|
|
||
| @Test | ||
| @Test() |
aleksandr-gringauz
previously approved these changes
Oct 16, 2025
| import fr.xgouchet.elmyr.junit5.ForgeExtension | ||
| import org.assertj.core.api.Assertions.assertThat | ||
| import org.junit.jupiter.api.BeforeEach | ||
| import org.junit.jupiter.api.RepeatedTest |
RUM supports tracking users anonymously through an anonymous user id. Other platforms add this id to the `usr` attribute in logs, but Android currently does not, so this adds support for it.
fuzzybinary
dismissed stale reviews from aleksandr-gringauz and 0xnm
via
514fcec
fuzzybinary
force-pushed
the
jward/anonymous-id-on-logs
branch
from
32fb2b1 to
514fcec
Compare
0xnm
approved these changes
Oct 16, 2025
aleksandr-gringauz
approved these changes
Oct 16, 2025
jonathanmos
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
RUM supports tracking users anonymously through an anonymous user id. Other platforms add this id to the
usrattribute in logs, but Android currently does not, so this adds support for it.Motivation
When implementing the new User and Account information APIs, Flutter integration tests that were checking for the anonymous user id in logs noticed it was missing.
Review checklist (to be filled by reviewers)