-
Notifications
You must be signed in to change notification settings - Fork 13
Correlate traces to profiles with the OTel ebpf profiler #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c0d6295
to
fe712b5
Compare
What do we think of using something like |
My 2 cents here: if the code does not add a big compile time, I think we will pay more in code readibility by adding #ifdef (as the code is split into multiple files) than we will win in compile time. It can be worth adding some comments to tell it will only work in Linux though. |
Noted, thanks for your input! |
ef34efa
to
a9f4269
Compare
5bbe694
to
475ab08
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
==========================================
+ Coverage 87.02% 87.13% +0.11%
==========================================
Files 80 80
Lines 5140 5194 +54
==========================================
+ Hits 4473 4526 +53
- Misses 667 668 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
475ab08
to
1282c6d
Compare
FYI, the global variables' naming is not set in stone. We plan on moving towards something more generic that does not use the elastic name. Additionally, I am in the process of a writing a problem statement regarding the way we share process data since dd-trace-cpp already shares that data through memfds. |
8984269
to
fb5241b
Compare
6dc9ac6
to
a817fa6
Compare
What's left to do here is figure how we want to handle runtime-ids in case of forks. |
7014f7a
to
45310ad
Compare
45310ad
to
b277e1c
Compare
* include/datadog/tracer.h * include/datadog/tracer_signature.h * src/datadog/tracer.cpp
65ca6c5
to
a6e0bae
Compare
* BUILD.bazel * cmake/compiler/clang.cmake * cmake/compiler/gcc.cmake * include/datadog/tls_storage.h * include/datadog/trace_segment.h * include/datadog/tracer.h * src/datadog/span.cpp * src/datadog/trace_segment.cpp * src/datadog/tracer.cpp
* include/datadog/environment.h * include/datadog/tracer.h * include/datadog/tracer_config.h * src/datadog/tracer.cpp * src/datadog/tracer_config.cpp
* test/test_tracer.cpp * test/test_tracer_config.cpp
The telemetry initialization now takes a few seconds. This delay is problematic for trace-to-profile correlation since it delays the initialization of the process storage, which the eBPF profiler checks once when it first encounters the process. * src/datadog/tracer.cpp
* README.md
a6e0bae
to
290c749
Compare
auto finalized_config = finalize_config(config); | ||
REQUIRE(finalized_config); | ||
Tracer tracer{*finalized_config}; | ||
REQUIRE(elastic_apm_profiling_correlation_process_storage_v1 != nullptr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have not yet defined what the process storage is going to look like, I am not validating the data that is stored in there. Once that is specified, we can look into decoding the contents.
else() | ||
message(FATAL_ERROR "Only aarch64 and x86-64 are supported (found: ${CMAKE_SYSTEM_PROCESSOR})") | ||
endif() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part could be conditioned to an expected $TLS_DIALECT set above
Description
Based on Elastic's work to correlate traces to profiles for Java using the ebpf profiler.