Use custom labels library for trace correlation with OTel eBPF profiler #211
+241
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsakeirouz
force-pushed
the
elsa/custom-labels-for-trace-corr
branch
7 times, most recently
from
0be754a to
f31f6b6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
- Coverage 87.02% 86.46% -0.56%
==========================================
Files 80 80
Lines 5140 5187 +47
==========================================
+ Hits 4473 4485 +12
- Misses 667 702 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
elsakeirouz
force-pushed
the
elsa/custom-labels-for-trace-corr
branch
2 times, most recently
from
fbbb2dd to
628c84e
Compare
* CMakeLists.txt * include/datadog/environment.h * include/datadog/tracer.h * include/datadog/tracer_config.h * include/datadog/tracer_signature.h * src/datadog/tracer.cpp * src/datadog/tracer_config.cpp
* include/datadog/tracer.h * src/datadog/otel_identifiers.h * src/datadog/span.cpp * src/datadog/trace_segment.cpp * src/datadog/tracer.cpp
elsakeirouz
force-pushed
the
elsa/custom-labels-for-trace-corr
branch
from
628c84e to
9ac8c36
Compare
|
/trigger-ci |
|
View all feedbacks in Devflow UI.
Started pipeline #64891338 |
BenchmarksBenchmark execution time: 2025-05-19 11:37:15 Comparing candidate commit 46dd99b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
elsakeirouz
force-pushed
the
elsa/custom-labels-for-trace-corr
branch
6 times, most recently
from
aaeee40 to
c0e1ff4
Compare
* CMakeLists.txt * cmake/deps/customlabels.cmake * include/datadog/tracer_signature.h * src/datadog/trace_segment.cpp
* BUILD.bazel * MODULE.bazel
The telemetry initialization now takes a few seconds. This delay is problematic for trace-to-profile correlation since it delays the initialization of the process storage, which the eBPF profiler checks once when it first encounters the process. * src/datadog/tracer.cpp
elsakeirouz
force-pushed
the
elsa/custom-labels-for-trace-corr
branch
from
c0e1ff4 to
46dd99b
Compare
r1viollet
reviewed
May 26, 2025
| endif() | ||
|
|
||
| include(CheckCompilerFlag) | ||
| check_compiler_flag(CXX "-ftls-dialect=${TLS_DIALECT}" TLS_DIALECT_OK) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR presents a different approach to trace to profile correlation with the OpenTelemetry eBPF profiler. It uses the custom-labels library.
Motivation
We want to compare different implementations to come up with an optimal version.
Additional Notes