Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Debugger Windows integration tests not running #6754

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

andrewlock
Copy link
Member

Summary of changes

Fixes the debugger tests filter so we run Windows Integration tests

Reason for change

The debugger tests were generating an invalid filter, so no tests have been running on Windows.

Implementation details

Fix the check for an empty Filter

Test coverage

This is the test

@andrewlock andrewlock added area:builds project files, build scripts, pipelines, versioning, releases, packages area:tests unit tests, integration tests labels Mar 11, 2025
@andrewlock andrewlock requested a review from a team as a code owner March 11, 2025 10:42
@andrewlock
Copy link
Member Author

andrewlock commented Mar 11, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6754) - mean (71ms)  : 65, 76
     .   : milestone, 71,
    master - mean (70ms)  : 66, 74
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6754) - mean (1,005ms)  : 987, 1023
     .   : milestone, 1005,
    master - mean (1,008ms)  : 986, 1030
     .   : milestone, 1008,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6754) - mean (103ms)  : 101, 105
     .   : milestone, 103,
    master - mean (103ms)  : 101, 105
     .   : milestone, 103,

    section CallTarget+Inlining+NGEN
    This PR (6754) - mean (691ms)  : 676, 706
     .   : milestone, 691,
    master - mean (685ms)  : 666, 704
     .   : milestone, 685,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6754) - mean (90ms)  : 88, 91
     .   : milestone, 90,
    master - mean (90ms)  : 88, 92
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (6754) - mean (645ms)  : 627, 662
     .   : milestone, 645,
    master - mean (645ms)  : 629, 661
     .   : milestone, 645,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6754) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6754) - mean (1,104ms)  : 1079, 1128
     .   : milestone, 1104,
    master - mean (1,105ms)  : 1080, 1129
     .   : milestone, 1105,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6754) - mean (269ms)  : 264, 274
     .   : milestone, 269,
    master - mean (268ms)  : 265, 272
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (6754) - mean (875ms)  : 842, 908
     .   : milestone, 875,
    master - mean (875ms)  : 851, 899
     .   : milestone, 875,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6754) - mean (262ms)  : 257, 267
     .   : milestone, 262,
    master - mean (262ms)  : 258, 265
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (6754) - mean (861ms)  : 823, 899
     .   : milestone, 861,
    master - mean (860ms)  : 824, 895
     .   : milestone, 860,

Loading

@andrewlock andrewlock changed the title Fix Debugger Windows integration tests Fix Debugger Windows integration tests and skip failing Mar 11, 2025
@andrewlock andrewlock changed the title Fix Debugger Windows integration tests and skip failing Fix Debugger Windows integration tests not running Mar 11, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 11, 2025

Datadog Report

All test runs 67f7132 🔗

2 Total Test Services: 1 Failed, 1 Passed
1 with Regressions

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Performance Regressions Test Service View
dd-trace-dotnet 1027 9 0 270814 5173 48h 7m 4.24s 1 Link
exploration_tests 0 0 0 22085 3 1h 28m 10.18s 0 Link

❌ Failed Tests (1027)

This report shows up to 5 failed tests.

  • LineProbeEmit100SnapshotsTest - Datadog.Trace.Debugger.IntegrationTests.ProbesTests - Details

    Expand for error
     Can't find source file for line probe
    
  • LineProbeEmit100SnapshotsTest - Datadog.Trace.Debugger.IntegrationTests.ProbesTests - Details

    Expand for error
     Can't find source file for line probe
    
  • LineProbeEmit100SnapshotsTest - Datadog.Trace.Debugger.IntegrationTests.ProbesTests - Details

    Expand for error
     Can't find source file for line probe
    
  • LineProbeEmit100SnapshotsTest - Datadog.Trace.Debugger.IntegrationTests.ProbesTests - Details

    Expand for error
     Can't find source file for line probe
    
  • LineProbeEmit100SnapshotsTest - Datadog.Trace.Debugger.IntegrationTests.ProbesTests - Details

    Expand for error
     Can't find source file for line probe
    

⌛ Performance Regressions vs Default Branch (1)

  • Profiler_cpu_walltime - scenarios 3.51s (+204.19ms, +6%) - Details

@dudikeleti dudikeleti requested a review from a team as a code owner March 25, 2025 17:50
@andrewlock
Copy link
Member Author

andrewlock commented Mar 25, 2025

Benchmarks Report for tracer 🐌

Benchmarks for #6754 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.119
  • 3 benchmarks are slower, with geometric mean 1.164
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.98μs 45.8ns 366ns 0.0151 0.00755 0 5.6 KB
master StartStopWithChild netcoreapp3.1 10μs 54.3ns 326ns 0.0206 0.0103 0 5.8 KB
master StartStopWithChild net472 16.2μs 72.6ns 281ns 1.06 0.325 0.106 6.22 KB
#6754 StartStopWithChild net6.0 7.96μs 45.1ns 335ns 0.0125 0.00416 0 5.61 KB
#6754 StartStopWithChild netcoreapp3.1 10.2μs 53.1ns 249ns 0.0202 0.0101 0 5.8 KB
#6754 StartStopWithChild net472 16.3μs 31.4ns 118ns 1.04 0.307 0.0971 6.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 491μs 310ns 1.2μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 638μs 517ns 1.93μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 873μs 1.22μs 4.72μs 0.431 0 0 3.3 KB
#6754 WriteAndFlushEnrichedTraces net6.0 498μs 358ns 1.34μs 0 0 0 2.7 KB
#6754 WriteAndFlushEnrichedTraces netcoreapp3.1 662μs 522ns 2.02μs 0 0 0 2.7 KB
#6754 WriteAndFlushEnrichedTraces net472 863μs 937ns 3.63μs 0.434 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 128μs 458ns 1.77μs 0.19 0 0 14.47 KB
master SendRequest netcoreapp3.1 148μs 195ns 730ns 0.225 0 0 17.27 KB
master SendRequest net472 0.000492ns 0.000318ns 0.00123ns 0 0 0 0 b
#6754 SendRequest net6.0 130μs 361ns 1.4μs 0.194 0 0 14.47 KB
#6754 SendRequest netcoreapp3.1 147μs 423ns 1.64μs 0.221 0 0 17.28 KB
#6754 SendRequest net472 0.000795ns 0.000261ns 0.00101ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6754

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.45 KB 41.66 KB 212 B 0.51%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 582μs 3.25μs 21.5μs 0.584 0 0 41.45 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 682μs 3.5μs 16.1μs 0.338 0 0 41.7 KB
master WriteAndFlushEnrichedTraces net472 872μs 3.96μs 15.3μs 8.62 2.59 0.431 53.32 KB
#6754 WriteAndFlushEnrichedTraces net6.0 603μs 3.46μs 31.5μs 0.59 0 0 41.66 KB
#6754 WriteAndFlushEnrichedTraces netcoreapp3.1 694μs 3.89μs 30.1μs 0.34 0 0 41.68 KB
#6754 WriteAndFlushEnrichedTraces net472 872μs 3.93μs 13.6μs 8.19 2.59 0.431 53.29 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.33μs 1.79ns 6.95ns 0.0145 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.75μs 1.86ns 7.21ns 0.0133 0 0 1.02 KB
master ExecuteNonQuery net472 2.01μs 2.2ns 8.24ns 0.156 0 0 987 B
#6754 ExecuteNonQuery net6.0 1.3μs 0.747ns 2.89ns 0.0144 0 0 1.02 KB
#6754 ExecuteNonQuery netcoreapp3.1 1.79μs 1.37ns 5.29ns 0.0134 0 0 1.02 KB
#6754 ExecuteNonQuery net472 2.1μs 1.37ns 5.12ns 0.157 0.00105 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6754

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.183 1,196.38 1,414.97

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.15μs 0.634ns 2.45ns 0.0138 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.49μs 0.462ns 1.73ns 0.0129 0 0 976 B
master CallElasticsearch net472 2.6μs 1.2ns 4.33ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.2μs 0.514ns 1.99ns 0.0132 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.75μs 0.904ns 3.13ns 0.0139 0 0 1.02 KB
master CallElasticsearchAsync net472 2.66μs 2ns 7.74ns 0.167 0 0 1.05 KB
#6754 CallElasticsearch net6.0 1.26μs 2.05ns 7.93ns 0.0139 0 0 976 B
#6754 CallElasticsearch netcoreapp3.1 1.56μs 0.835ns 3.12ns 0.0133 0 0 976 B
#6754 CallElasticsearch net472 2.6μs 1.74ns 6.74ns 0.157 0 0 995 B
#6754 CallElasticsearchAsync net6.0 1.41μs 0.769ns 2.98ns 0.0135 0 0 952 B
#6754 CallElasticsearchAsync netcoreapp3.1 1.73μs 0.601ns 2.25ns 0.0137 0 0 1.02 KB
#6754 CallElasticsearchAsync net472 2.59μs 1.54ns 5.76ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.21μs 0.456ns 1.77ns 0.0134 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.64μs 0.625ns 2.34ns 0.0122 0 0 952 B
master ExecuteAsync net472 1.83μs 0.347ns 1.3ns 0.145 0 0 915 B
#6754 ExecuteAsync net6.0 1.26μs 0.914ns 3.42ns 0.013 0 0 952 B
#6754 ExecuteAsync netcoreapp3.1 1.74μs 1.04ns 3.88ns 0.013 0 0 952 B
#6754 ExecuteAsync net472 1.81μs 0.789ns 3.06ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.44μs 1.36ns 5.27ns 0.0314 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.53μs 1.93ns 7.23ns 0.0386 0 0 2.85 KB
master SendAsync net472 7.54μs 14.4ns 55.6ns 0.493 0 0 3.12 KB
#6754 SendAsync net6.0 4.46μs 2.59ns 9.7ns 0.0312 0 0 2.31 KB
#6754 SendAsync netcoreapp3.1 5.44μs 3.09ns 11.2ns 0.0379 0 0 2.85 KB
#6754 SendAsync net472 7.6μs 1.88ns 7.04ns 0.493 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6754

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1 1.119 2,332.53 2,083.78

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.64μs 0.716ns 2.68ns 0.0236 0 0 1.69 KB
master EnrichedLog netcoreapp3.1 2.33μs 0.579ns 2.09ns 0.0222 0 0 1.69 KB
master EnrichedLog net472 2.54μs 1.68ns 6.5ns 0.258 0 0 1.62 KB
#6754 EnrichedLog net6.0 1.57μs 1.09ns 4.07ns 0.0239 0 0 1.69 KB
#6754 EnrichedLog netcoreapp3.1 2.08μs 1.21ns 4.54ns 0.0219 0 0 1.69 KB
#6754 EnrichedLog net472 2.68μs 3.08ns 11.5ns 0.258 0 0 1.62 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 111μs 143ns 535ns 0.0559 0 0 4.3 KB
master EnrichedLog netcoreapp3.1 116μs 194ns 753ns 0.058 0 0 4.3 KB
master EnrichedLog net472 150μs 164ns 637ns 0.669 0.223 0 4.49 KB
#6754 EnrichedLog net6.0 112μs 120ns 466ns 0.056 0 0 4.3 KB
#6754 EnrichedLog netcoreapp3.1 117μs 163ns 631ns 0.0589 0 0 4.3 KB
#6754 EnrichedLog net472 151μs 71.1ns 275ns 0.68 0.227 0 4.49 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.17μs 2.24ns 8.67ns 0.0305 0 0 2.25 KB
master EnrichedLog netcoreapp3.1 4.41μs 1.21ns 4.51ns 0.0303 0 0 2.25 KB
master EnrichedLog net472 4.7μs 1ns 3.76ns 0.328 0 0 2.07 KB
#6754 EnrichedLog net6.0 3.03μs 0.95ns 3.68ns 0.0318 0 0 2.25 KB
#6754 EnrichedLog netcoreapp3.1 4.31μs 24.8ns 202ns 0.0312 0 0 2.25 KB
#6754 EnrichedLog net472 4.9μs 2.14ns 8.29ns 0.329 0 0 2.07 KB
Benchmarks.Trace.RedisBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6754

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 1.175 1,246.61 1,464.89

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.25μs 3.27ns 12.7ns 0.0162 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.78μs 0.862ns 3.34ns 0.015 0 0 1.14 KB
master SendReceive net472 2.09μs 0.782ns 2.92ns 0.183 0 0 1.16 KB
#6754 SendReceive net6.0 1.46μs 0.646ns 2.5ns 0.016 0 0 1.14 KB
#6754 SendReceive netcoreapp3.1 1.77μs 1.18ns 4.57ns 0.0151 0 0 1.14 KB
#6754 SendReceive net472 2.07μs 0.446ns 1.67ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.83μs 7.2ns 27.9ns 0.0223 0 0 1.62 KB
master EnrichedLog netcoreapp3.1 3.94μs 2.26ns 8.77ns 0.0216 0 0 1.67 KB
master EnrichedLog net472 4.5μs 2.64ns 10.2ns 0.328 0 0 2.07 KB
#6754 EnrichedLog net6.0 2.71μs 0.921ns 3.19ns 0.023 0 0 1.62 KB
#6754 EnrichedLog netcoreapp3.1 3.94μs 2.11ns 8.19ns 0.0216 0 0 1.67 KB
#6754 EnrichedLog net472 4.46μs 8.5ns 31.8ns 0.327 0 0 2.07 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6754

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.134 411.86 466.85

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 412ns 0.155ns 0.599ns 0.00817 0 0 576 B
master StartFinishSpan netcoreapp3.1 626ns 0.312ns 1.13ns 0.00791 0 0 576 B
master StartFinishSpan net472 604ns 0.18ns 0.674ns 0.0916 0 0 578 B
master StartFinishScope net6.0 569ns 0.263ns 0.982ns 0.00963 0 0 696 B
master StartFinishScope netcoreapp3.1 721ns 1.25ns 4.83ns 0.00936 0 0 696 B
master StartFinishScope net472 862ns 0.413ns 1.43ns 0.104 0 0 658 B
#6754 StartFinishSpan net6.0 467ns 0.367ns 1.42ns 0.00805 0 0 576 B
#6754 StartFinishSpan netcoreapp3.1 572ns 0.425ns 1.59ns 0.00772 0 0 576 B
#6754 StartFinishSpan net472 663ns 0.449ns 1.74ns 0.0916 0 0 578 B
#6754 StartFinishScope net6.0 550ns 0.629ns 2.44ns 0.00973 0 0 696 B
#6754 StartFinishScope netcoreapp3.1 717ns 0.68ns 2.63ns 0.00927 0 0 696 B
#6754 StartFinishScope net472 884ns 0.305ns 1.18ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 712ns 0.347ns 1.35ns 0.00966 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 920ns 0.26ns 1.01ns 0.00956 0 0 696 B
master RunOnMethodBegin net472 1.1μs 0.321ns 1.2ns 0.104 0 0 658 B
#6754 RunOnMethodBegin net6.0 651ns 0.26ns 0.937ns 0.00976 0 0 696 B
#6754 RunOnMethodBegin netcoreapp3.1 937ns 0.34ns 1.27ns 0.00937 0 0 696 B
#6754 RunOnMethodBegin net472 1.12μs 0.232ns 0.837ns 0.104 0 0 658 B

@dudikeleti dudikeleti force-pushed the andrew/ci/try-fix-debugger-windows-tests branch from 3903fad to 67f7132 Compare March 26, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages area:tests unit tests, integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants