[BUG] compile error after dependency update to version 1.70.1

[mibo-fdc]

Version of dd-trace-go
1.70.1

Describe what happened:
After dependency upgrades this compile error is raised from the package:
gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer

gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer

../../../../../go/pkg/mod/gopkg.in/!data!dog/[email protected]/ddtrace/tracer/tracer.go:339:34: cannot use t.statsd (variable of type "gopkg.in/DataDog/dd-trace-go.v1/internal".StatsdClient) as runtimemetrics.partialStatsdClientInterface value in argument to runtimemetrics.Start: "gopkg.in/DataDog/dd-trace-go.v1/internal".StatsdClient does not implement runtimemetrics.partialStatsdClientInterface (missing method DistributionSamples)

Describe what you expected:
No compiler error. It seems to be dependency-related, but the error is from the library itself. I see no combination of dependency updates that causes this.

Steps to reproduce the issue:
Dependency update with go get -u ./... and go mod tidy. After this, the error above occurred in the builds.

Additional environment details (Version of Go, Operating System, etc.):
Go 1.23.4, across operation systems (this error also occurs on CI/Linux and on macOS)

[darccio]

@mibo-fdc Thanks for reaching out. The root cause for this error is go get -u ./... upgrading to the latest commit in github.com/DataDog/go-runtime-metrics-internal that introduced a breaking change. It's happening also in our smoke tests since today.

A workaround for this is to run go get github.com/DataDog/go-runtime-metrics-internal@194426bbbd59 in the meantime.

[mibo-fdc]

Thanks for the fast response. I tried your workaround, but the error stays the same.

I know have
github.com/DataDog/go-runtime-metrics-internal v0.0.0-20241106155157-194426bbbd59 // indirect
in the go.mod as an indirect dependency. This should be enough to fix the issue?

[darccio]

@mibo-fdc It should be enough. See the screenshot below:

Did you run again go get -u ./... after pinning the version? Another way to ensure the library is properly pinned is using a replace directive like this:

go mod edit -replace=github.com/DataDog/go-runtime-metrics-internal=github.com/DataDog/go-runtime-metrics-internal@194426bbbd59
go mod tidy

I did it locally and it also worked (after running again go get -u ./...):

[mibo-fdc]

No, I did not update the version again after the go get.
However, with the version pinning, it works. Thanks for the help!

[felixge]

This should be fixed now. See this comment for more details and how we're planning to prevent this kind of issue from appearing again in the future. Sorry for the trouble this caused 🙇